[FW][FIX] evaluation: behavior for invalid range arguments #3520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When user provides an invalid sheet name in range arguments of a function, it performs computations on data of specified range from active sheet by default and returns misleading results. This commit changes the behavior to throw an error instead of performing any kind of computations. Task ID : 3619144 X-original-commit: 0060f5a
|
This PR targets saas-16.3 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@khpa-odoo @pro-odoo the next pull request (#3523) is in conflict. You can merge the chain up to here by saying
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
fw-bot r+
…On Thu, Jan 25, 2024 at 1:40 PM Otis - Odoo Forward-Port Steward [bot] < ***@***.***> wrote:
@khpa-odoo <https://github.com/khpa-odoo> @pro-odoo
<https://github.com/pro-odoo> the next pull request (#3523
<#3523>) is in conflict. You
can merge the chain up to here by saying
@fw-bot <https://github.com/fw-bot> r+
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port
—
Reply to this email directly, view it on GitHub
<#3520 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHFIBHWJ4DM46WC5552TXWTYQJHFDAVCNFSM6AAAAABCKNW5X2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJQGEZDGMJQGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
robodoo
pushed a commit
that referenced
this pull request
Jan 25, 2024
When user provides an invalid sheet name in range arguments of a function, it performs computations on data of specified range from active sheet by default and returns misleading results. This commit changes the behavior to throw an error instead of performing any kind of computations. Task ID : 3619144 closes #3520 X-original-commit: 0060f5a Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When user provides an invalid sheet name in range arguments of a function, it performs computations on
data of specified range from active sheet by default and returns misleading results.
This PR changes the behavior to throw an error instead of performing any kind of computations.
Task: : 3619144
review checklist
Forward-Port-Of: #3511
Forward-Port-Of: #3361