Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] evaluation: behavior for invalid range arguments #3523

Closed

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Jan 25, 2024

Description:

When user provides an invalid sheet name in range arguments of a function, it performs computations on
data of specified range from active sheet by default and returns misleading results.

This PR changes the behavior to throw an error instead of performing any kind of computations.

Task: : 3619144

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #3511
Forward-Port-Of: #3361

@robodoo
Copy link
Collaborator

robodoo commented Jan 25, 2024

@fw-bot
Copy link
Collaborator Author

fw-bot commented Jan 25, 2024

@khpa-odoo @pro-odoo cherrypicking of pull request #3361 failed.

stdout:

CONFLICT (modify/delete): src/plugins/ui/evaluation.ts deleted in HEAD and modified in e98a1757d ([FIX] evaluation: behavior for invalid range arguments).  Version e98a1757d ([FIX] evaluation: behavior for invalid range arguments) of src/plugins/ui/evaluation.ts left in tree.
Auto-merging tests/formulas/compiler.test.ts
Auto-merging tests/functions/module_lookup.test.ts

stderr:

13:40:06.296587 git.c:463               trace: built-in: git cherry-pick e98a1757da87cf3702857be2600864b94df56cc0
error: could not apply e98a1757d... [FIX] evaluation: behavior for invalid range arguments
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
----------
status:

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

When user provides an invalid sheet name in range arguments of a function,
it performs computations on data of specified range from active sheet by default
and returns misleading results.

This commit changes the behavior to throw an error instead of performing any
kind of computations.

Task ID : 3619144

X-original-commit: 0060f5a
@khpa-odoo khpa-odoo force-pushed the saas-16.4-15.0-fix-invalid-range-args-khpa-4ccZ-fw branch from f610471 to 941b029 Compare January 25, 2024 12:57
@khpa-odoo
Copy link
Contributor

Conflicts resolved 👍 @pro-odoo

@pro-odoo
Copy link
Collaborator

robodoo r+

robodoo pushed a commit that referenced this pull request Jan 26, 2024
When user provides an invalid sheet name in range arguments of a function,
it performs computations on data of specified range from active sheet by default
and returns misleading results.

This commit changes the behavior to throw an error instead of performing any
kind of computations.

Task ID : 3619144

closes #3523

X-original-commit: 0060f5a
Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
@robodoo robodoo closed this Jan 26, 2024
@fw-bot fw-bot deleted the saas-16.4-15.0-fix-invalid-range-args-khpa-4ccZ-fw branch February 9, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants