[FIX] formula assistant: localize argument separator #3790
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The argument separator in the formula assistant was not localized, it was always a comma no matter the locale. This commit fixes it. Task: 3789860
rrahir
reviewed
Mar 18, 2024
| @@ -73,6 +73,10 @@ export class FunctionDescriptionProvider extends Component<Props> { | |||
| this.assistantState.allowCellSelectionBehind = false; | |||
| }, 2000) as unknown as number; | |||
| } | |||
|
|
|||
| get formulaArgSeparator() { | |||
| return this.env.model.getters.getLocale().formulaArgSeparator + " "; | |||
There was a problem hiding this comment.
Suggested change
| return this.env.model.getters.getLocale().formulaArgSeparator + " "; | |
| return this.env.model.getters.getLocale().formulaArgSeparator + "\u00A0"; |
Not sure if the unbreakable space was necessary though
There was a problem hiding this comment.
I didn't put an unbreaking space because it looks like simple spaces are preserved with t-esc. And it makes it harder to read the code if you don't know by heart unicode characters ;)
robodoo
pushed a commit
that referenced
this pull request
Mar 21, 2024
The argument separator in the formula assistant was not localized, it was always a comma no matter the locale. This commit fixes it. closes #3790 Task: 3789860 Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
This was referenced Mar 21, 2024
|
Forward-porting to 'saas-17.2' (from #3882). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The argument separator in the formula assistant was not localized, it was always a comma no matter the locale. This commit fixes it.
Task: : 3789860
review checklist