Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] formula assistant: localize argument separator #3883

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Mar 22, 2024

Description

The argument separator in the formula assistant was not localized, it was always a comma no matter the locale. This commit fixes it.

Task: : 3789860

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #3871
Forward-Port-Of: #3790

@robodoo
Copy link
Collaborator

robodoo commented Mar 22, 2024

@fw-bot
Copy link
Collaborator Author

fw-bot commented Mar 22, 2024

This PR targets saas-17.2 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@fw-bot
Copy link
Collaborator Author

fw-bot commented Mar 22, 2024

@hokolomopo @LucasLefevre ci/runbot failed on this forward-port PR

The argument separator in the formula assistant was not localized, it
was always a comma no matter the locale. This commit fixes it.

Task: 3789860
X-original-commit: 7e7b069
@hokolomopo hokolomopo force-pushed the saas-17.2-saas-16.4-formula-assisstant-separator-locale-adrm-TTER-fw branch from 9a95408 to de0911e Compare March 22, 2024 09:49
@hokolomopo
Copy link
Contributor

@robodoo r+

@fw-bot
Copy link
Collaborator Author

fw-bot commented Mar 22, 2024

@hokolomopo @LucasLefevre this PR was modified / updated and has become a normal PR. It should be merged the normal way (via @robodoo)

@fw-bot
Copy link
Collaborator Author

fw-bot commented Mar 22, 2024

Forward-porting to 'saas-17.2' (from #3882).

robodoo pushed a commit that referenced this pull request Mar 22, 2024
The argument separator in the formula assistant was not localized, it
was always a comma no matter the locale. This commit fixes it.

closes #3883

Task: 3789860
X-original-commit: 7e7b069
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Signed-off-by: Adrien Minne (adrm) <adrm@odoo.com>
@robodoo robodoo closed this Mar 22, 2024
@fw-bot fw-bot deleted the saas-17.2-saas-16.4-formula-assisstant-separator-locale-adrm-TTER-fw branch April 5, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants