[FW][FIX] GridComposer: Reset the cell reference visibility on stop edition #3791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets saas-16.3 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@rrahir @LucasLefevre ci/runbot failed on this forward-port PR |
Following the fix in PR #3456, the `GridComposer` is now a persistent component and one of its properties `isCellReferenceVisibility` did not account for this. How to reproduce the bug: - start editing a cell in the grid - scroll the viewport such that the celle refecerence is visible above the composer - stop the edition - start editing another cell -> the cell reference is already visible even though it should only appear when the composer box is no longer aligned with the cell position in the viewport. Task: 3736211 X-original-commit: 6d51b09
rrahir
force-pushed
the
saas-16.3-saas-16.2-fix-cell-ref-rar-Mdaw-fw
branch
from
096c65a
to
2b221ee
Compare
|
@robodoo r+ |
|
@rrahir @LucasLefevre this PR was modified / updated and has become a normal PR. It should be merged the normal way (via @robodoo) |
14 tasks
robodoo
pushed a commit
that referenced
this pull request
Mar 6, 2024
Following the fix in PR #3456, the `GridComposer` is now a persistent component and one of its properties `isCellReferenceVisibility` did not account for this. How to reproduce the bug: - start editing a cell in the grid - scroll the viewport such that the celle refecerence is visible above the composer - stop the edition - start editing another cell -> the cell reference is already visible even though it should only appear when the composer box is no longer aligned with the cell position in the viewport. closes #3791 Task: 3736211 X-original-commit: 6d51b09 Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com> Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
14 tasks
This was referenced Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the fix in PR #3456, the
GridComposeris now a persistent component and one of its propertiesisCellReferenceVisibilitydid not account for this.How to reproduce the bug:
-> the cell reference is already visible even though it should only appear when the composer box is no longer aligned with the cell position in the viewport.
Task: 3736211
Description:
description of this task, what is implemented and why it is implemented that way.
Task: : TASK_ID
review checklist
Forward-Port-Of: #3649