[FIX] TextValueProvider: duplicate values in dropdown list #3843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhrp-odoo
force-pushed
the
17.0-fix-dropdown-list-duplicate-values-dhrp
branch
from
d00a388
to
926668a
Compare
dhrp-odoo
force-pushed
the
17.0-fix-dropdown-list-duplicate-values-dhrp
branch
2 times, most recently
from
a6b22af
to
8f92f69
Compare
hokolomopo
reviewed
Mar 25, 2024
| }); | ||
|
|
||
| test("Duplicate values will be removed before sending proposals to the autocomplete dropdown in data validation with list", async () => { | ||
| addDataValidation(model, "A1", "id", { |
There was a problem hiding this comment.
also test that the data validation plugin has the filtered values since you filter them in the plugin now.
There was a problem hiding this comment.
I've added a test for the plugin, thanks!
Previously, when creating data validation with either a list of values or a range of values, it resulted in an error being thrown by the auto-complete dropdown. This occurred because the values were being used as keys, and by definition, having duplicate keys in a list is nonsensical. This commit addresses the problem by eliminating duplicate values from the list. TaskID: 3768392
dhrp-odoo
force-pushed
the
17.0-fix-dropdown-list-duplicate-values-dhrp
branch
from
8f92f69
to
088e01f
Compare
14 tasks
This was referenced Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Previously, when creating data validation with either a list of values or a range of values, it resulted in an error being thrown by the auto-complete dropdown. This occurred because the values were being used as keys, and by definition, having duplicate keys in a list is nonsensical.
This PR addresses the problem by eliminating duplicate values from the list.
Task: : 3768392
review checklist