[FW][FIX] TextValueProvider: duplicate values in dropdown list #3926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when creating data validation with either a list of values or a range of values, it resulted in an error being thrown by the auto-complete dropdown. This occurred because the values were being used as keys, and by definition, having duplicate keys in a list is nonsensical. This commit addresses the problem by eliminating duplicate values from the list. Taskid: 3768392 X-original-commit: c2eed35
|
This PR targets saas-17.1 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@dhrp-odoo @hokolomopo the next pull request (#3927) is in conflict. You can merge the chain up to here by saying
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@fw-bot r+ |
robodoo
pushed a commit
that referenced
this pull request
Mar 26, 2024
Previously, when creating data validation with either a list of values or a range of values, it resulted in an error being thrown by the auto-complete dropdown. This occurred because the values were being used as keys, and by definition, having duplicate keys in a list is nonsensical. This commit addresses the problem by eliminating duplicate values from the list. closes #3926 Taskid: 3768392 X-original-commit: c2eed35 Signed-off-by: Adrien Minne (adrm) <adrm@odoo.com> Signed-off-by: Dhrutik Patel (dhrp) <dhrp@odoo.com>
fw-bot
deleted the
saas-17.1-17.0-fix-dropdown-list-duplicate-values-dhrp-bS9x-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Previously, when creating data validation with either a list of values or a range of values, it resulted in an error being thrown by the auto-complete dropdown. This occurred because the values were being used as keys, and by definition, having duplicate keys in a list is nonsensical.
This PR addresses the problem by eliminating duplicate values from the list.
Task: : 3768392
review checklist
Forward-Port-Of: #3843