Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] bottom_bar: disable sheet drag & drop in readonly #3870

Closed
wants to merge 1 commit into from
Closed

[FIX] bottom_bar: disable sheet drag & drop in readonly #3870

wants to merge 1 commit into from

Conversation

hokolomopo
Copy link
Contributor

Description

When the sheet is readonly, the bottom bar should not allow the user to drag and drop the sheet. Before this commit, dragging a sheet was possible, but the sheet was not moved when dropping. Now we prevent dragging the sheet when it is readonly.

Task: : 3820888

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@hokolomopo
[FIX] bottom_bar: disable sheet drag & drop in readonly
d5068ab 
When the sheet is readonly, the bottom bar should not allow the user to
drag and drop the sheet. Before this commit, dragging a sheet was
possible, but the sheet was not moved when dropping. Now we prevent
dragging the sheet when it is readonly.

Task: 3820888
@robodoo
Copy link
Collaborator

robodoo commented Mar 21, 2024

Pull request status dashboard.

LucasLefevre
LucasLefevre approved these changes Mar 25, 2024
View reviewed changes
Copy link
Collaborator

@LucasLefevre LucasLefevre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo r+

robodoo pushed a commit that referenced this pull request Mar 25, 2024
@hokolomopo
[FIX] bottom_bar: disable sheet drag & drop in readonly
56bc356 
When the sheet is readonly, the bottom bar should not allow the user to
drag and drop the sheet. Before this commit, dragging a sheet was
possible, but the sheet was not moved when dropping. Now we prevent
dragging the sheet when it is readonly.

closes #3870

Task: 3820888
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
@robodoo robodoo closed this Mar 25, 2024
This was referenced Mar 25, 2024
Closed
Closed
Closed
Closed
Closed
@fw-bot fw-bot deleted the saas-16.3-bottom-bar-drag-and-drop-readonly-adrm branch April 8, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucasLefevre LucasLefevre LucasLefevre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hokolomopo @robodoo @LucasLefevre