[FW][FIX] bottom_bar: disable sheet drag & drop in readonly #3913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the sheet is readonly, the bottom bar should not allow the user to drag and drop the sheet. Before this commit, dragging a sheet was possible, but the sheet was not moved when dropping. Now we prevent dragging the sheet when it is readonly. Task: 3820888 X-original-commit: 56bc356
|
This PR targets saas-17.2 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
14 tasks
robodoo
pushed a commit
that referenced
this pull request
Mar 25, 2024
When the sheet is readonly, the bottom bar should not allow the user to drag and drop the sheet. Before this commit, dragging a sheet was possible, but the sheet was not moved when dropping. Now we prevent dragging the sheet when it is readonly. closes #3913 Task: 3820888 X-original-commit: 56bc356 Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com> Signed-off-by: Adrien Minne (adrm) <adrm@odoo.com>
fw-bot
deleted the
saas-17.2-saas-16.3-bottom-bar-drag-and-drop-readonly-adrm-BJs7-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the sheet is readonly, the bottom bar should not allow the user to drag and drop the sheet. Before this commit, dragging a sheet was possible, but the sheet was not moved when dropping. Now we prevent dragging the sheet when it is readonly.
Task: : 3820888
review checklist
Forward-Port-Of: #3870