Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] BottomBarSheet: Rename a sheet with style content on Firefox #3922

Closed

Commits on Mar 25, 2024

  1. [FIX] BottomBarSheet: Rename a sheet with style content on Firefox

    The issue addressed in PR #3351 unfortunately used a
    `contentEditable` value that is not compatible with Firefox [1]
    
    This revision implements the first strategy explored by the
    aforementioned PR by removing the full format from  the contenteditable
    span when we stop the edition.
    
    Testing required to define some properties as JSdom does not properly
    support the implementation of innerText (see [2])
    
    [1]: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/contenteditable#browser_compatibility
    [2]: jsdom/jsdom#1245
    
    Task: 3754944
    X-original-commit: ed7d3fa
    rrahir committed Mar 25, 2024
    Copy the full SHA
    fc6b8f2 View commit details
    Browse the repository at this point in the history