Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PERF] helpers: faster default cell height #3961

Closed
wants to merge 1 commit into from
Closed

[PERF] helpers: faster default cell height #3961

wants to merge 1 commit into from

Conversation

LucasLefevre
Copy link
Collaborator

Description:

cell.content can be expensive for formulas as the content is a computed property which rebuilds the entire formula string based on the tokens and the dependency ranges.

With this commit, we first check if the cell is a formula, in which case we know it has a content.

When loading the Timesheet report on odoo.com, the total time spent in getDefaultCellHeight goes from ~280ms (~2.5%) to less than 5ms (0.0%)

Task: : 3845472

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@LucasLefevre
[PERF] helpers: faster default cell height
b72473f 
`cell.content` can be expensive for formulas as the content is a computed
property which rebuilds the entire formula string based on the tokens
and the dependency ranges.

With this commit, we first check if the cell is a formula, in which case we
know it has a content.

When loading the Timesheet report on odoo.com, the total time spent in
`getDefaultCellHeight` goes from ~280ms (~2.5%) to less than 5ms (0.0%)

Task: 3845472
@robodoo
Copy link
Collaborator

robodoo commented Apr 2, 2024

Pull request status dashboard.

pro-odoo
pro-odoo approved these changes Apr 3, 2024
View reviewed changes
Copy link
Collaborator

@pro-odoo pro-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo r+

@robodoo robodoo closed this in 6c96ded Apr 3, 2024
@fw-bot fw-bot mentioned this pull request Apr 3, 2024
Closed
14 tasks
This was referenced Apr 3, 2024
Closed
Closed
@fw-bot fw-bot deleted the 17.0-faster-default-cell-height-lul branch April 17, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pro-odoo pro-odoo pro-odoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LucasLefevre @robodoo @pro-odoo