[FW][PERF] helpers: faster default cell height #3973
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cell.content` can be expensive for formulas as the content is a computed property which rebuilds the entire formula string based on the tokens and the dependency ranges. With this commit, we first check if the cell is a formula, in which case we know it has a content. When loading the Timesheet report on odoo.com, the total time spent in `getDefaultCellHeight` goes from ~280ms (~2.5%) to less than 5ms (0.0%) Task: 3845472 X-original-commit: 6c96ded
|
This PR targets saas-17.2 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
14 tasks
robodoo
pushed a commit
that referenced
this pull request
Apr 3, 2024
`cell.content` can be expensive for formulas as the content is a computed property which rebuilds the entire formula string based on the tokens and the dependency ranges. With this commit, we first check if the cell is a formula, in which case we know it has a content. When loading the Timesheet report on odoo.com, the total time spent in `getDefaultCellHeight` goes from ~280ms (~2.5%) to less than 5ms (0.0%) closes #3973 Task: 3845472 X-original-commit: 6c96ded Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
fw-bot
deleted the
saas-17.2-17.0-faster-default-cell-height-lul-gAM3-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
cell.contentcan be expensive for formulas as the content is a computed property which rebuilds the entire formula string based on the tokens and the dependency ranges.With this commit, we first check if the cell is a formula, in which case we know it has a content.
When loading the Timesheet report on odoo.com, the total time spent in
getDefaultCellHeightgoes from ~280ms (~2.5%) to less than 5ms (0.0%)Task: : 3845472
review checklist
Forward-Port-Of: #3961