Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FW][PERF] helpers: faster default cell height #3973

Closed
wants to merge 1 commit into from
Closed

[FW][PERF] helpers: faster default cell height #3973

wants to merge 1 commit into from

Commits on Apr 3, 2024

  1. [PERF] helpers: faster default cell height 

    `cell.content` can be expensive for formulas as the content is a computed
property which rebuilds the entire formula string based on the tokens
and the dependency ranges.

With this commit, we first check if the cell is a formula, in which case we
know it has a content.

When loading the Timesheet report on odoo.com, the total time spent in
`getDefaultCellHeight` goes from ~280ms (~2.5%) to less than 5ms (0.0%)

Task: 3845472
X-original-commit: 6c96ded
    @LucasLefevre
    LucasLefevre committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    b44cd19 View commit details
    Browse the repository at this point in the history