[FIX] sheetview: pageUp/Down with frozen rows #3981
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anhe-odoo
reviewed
Apr 8, 2024
hokolomopo
force-pushed
the
saas-16.3-frozen-pane-page-down-adrm
branch
from
a3acb53
to
1b3660d
Compare
rrahir
force-pushed
the
saas-16.3-frozen-pane-page-down-adrm
branch
from
1b3660d
to
3933c8a
Compare
There was two issues with the commands `SHIFT_VIEWPORT_UP/DOWN` when some rows were frozen: - the viewport was never scrolled all the way down to the last row with pageDown - pageDown/Up scrolled more than a "page" (the size of the viewport) This commit fixes both issues. Also replaced calls from `getActiveMainViewport` to `getMainInternalViewport` in the plugin `SheetView` as it needs slightly less computations. Task: 3847414
hokolomopo
force-pushed
the
saas-16.3-frozen-pane-page-down-adrm
branch
from
3933c8a
to
eee0c5c
Compare
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Apr 10, 2024
There was two issues with the commands `SHIFT_VIEWPORT_UP/DOWN` when some rows were frozen: - the viewport was never scrolled all the way down to the last row with pageDown - pageDown/Up scrolled more than a "page" (the size of the viewport) This commit fixes both issues. Also replaced calls from `getActiveMainViewport` to `getMainInternalViewport` in the plugin `SheetView` as it needs slightly less computations. closes #3981 Task: 3847414 Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
14 tasks
This was referenced Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was two issues with the commands
SHIFT_VIEWPORT_UP/DOWNwhen some rows were frozen:This commit fixes both issues.
Also replaced calls from
getActiveMainViewporttogetMainInternalViewportin the plugin
SheetViewas it needs slightly less computations.Task: : 3847414
review checklist