Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] sheetview: pageUp/Down with frozen rows #4027

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Apr 10, 2024

Description

There was two issues with the commands SHIFT_VIEWPORT_UP/DOWN when some rows were frozen:

  • the viewport was never scrolled all the way down to the last row with pageDown
  • pageDown/Up scrolled more than a "page" (the size of the viewport)

This commit fixes both issues.

Also replaced calls from getActiveMainViewport to getMainInternalViewport
in the plugin SheetView as it needs slightly less computations.

Task: : 3847414

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #3981

@robodoo
Copy link
Collaborator

robodoo commented Apr 10, 2024

@fw-bot
Copy link
Collaborator Author

fw-bot commented Apr 10, 2024

@hokolomopo @rrahir cherrypicking of pull request #3981 failed.

stdout:

Auto-merging src/plugins/ui_stateful/sheetview.ts
CONFLICT (content): Merge conflict in src/plugins/ui_stateful/sheetview.ts
Auto-merging tests/plugins/sheetview.test.ts

stderr:

08:59:31.475484 git.c:463               trace: built-in: git cherry-pick eee0c5c56123e8c4de562b8e95831e28a7f6b528
error: could not apply eee0c5c56... [FIX] sheetview: pageUp/Down with frozen rows
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
----------
status:

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

There was two issues with the commands `SHIFT_VIEWPORT_UP/DOWN` when
some rows were frozen:

- the viewport was never scrolled all the way down to the last row
with pageDown
- pageDown/Up scrolled more than a "page" (the size of the viewport)

This commit fixes both issues.

Also replaced calls from `getActiveMainViewport` to `getMainInternalViewport`
in the plugin `SheetView` as it needs slightly less computations.

Task: 3847414
X-original-commit: 51860d7
@hokolomopo hokolomopo force-pushed the saas-16.4-saas-16.3-frozen-pane-page-down-adrm-l2S3-fw branch from 94dce3a to b704333 Compare April 10, 2024 07:20
@hokolomopo
Copy link
Contributor

@robodoo r+

robodoo pushed a commit that referenced this pull request Apr 10, 2024
There was two issues with the commands `SHIFT_VIEWPORT_UP/DOWN` when
some rows were frozen:

- the viewport was never scrolled all the way down to the last row
with pageDown
- pageDown/Up scrolled more than a "page" (the size of the viewport)

This commit fixes both issues.

Also replaced calls from `getActiveMainViewport` to `getMainInternalViewport`
in the plugin `SheetView` as it needs slightly less computations.

closes #4027

Task: 3847414
X-original-commit: 51860d7
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
Signed-off-by: Adrien Minne (adrm) <adrm@odoo.com>
@robodoo robodoo closed this Apr 10, 2024
@fw-bot fw-bot deleted the saas-16.4-saas-16.3-frozen-pane-page-down-adrm-l2S3-fw branch April 24, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants