Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] Checkbox: unused className prop in checkbox #3989

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Apr 5, 2024

Description:

  • Modified the checkbox.xml file to incorporate the className prop within the Checkbox component.

Task: : TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #3986
Forward-Port-Of: #3985

Modified the checkbox.xml file to incorporate the
className prop within the Checkbox component

X-original-commit: 87b7e62
@robodoo
Copy link
Collaborator

robodoo commented Apr 5, 2024

@fw-bot
Copy link
Collaborator Author

fw-bot commented Apr 5, 2024

@dhrp-odoo @LucasLefevre this PR targets master and is the last of the forward-port chain.

To merge the full chain, use

@fw-bot r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@LucasLefevre
Copy link
Collaborator

LucasLefevre commented Apr 5, 2024 via email

robodoo pushed a commit that referenced this pull request Apr 5, 2024
Modified the checkbox.xml file to incorporate the
className prop within the Checkbox component

closes #3989

X-original-commit: 87b7e62
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
@robodoo robodoo closed this Apr 5, 2024
@robodoo robodoo added the 17.3 label Apr 5, 2024
@fw-bot fw-bot deleted the master-saas-17.1-fix-unused-classname-prop-in-checkbox-dhrp-wVS0-fw branch April 19, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants