Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FW][FIX] Composer: pressing enter in the link editor #4032

Closed
wants to merge 1 commit into from
Closed

[FW][FIX] Composer: pressing enter in the link editor #4032

wants to merge 1 commit into from

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Apr 10, 2024

Description:

Previously, pressing Enter in the link editor would inadvertently open the grid composer in edit mode, which was not the expected behavior. This PR addresses the issue by adding a check in the onInput method of the composer component.

Task: : 3796114

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #4009
Forward-Port-Of: #3931

@dhrp-odoo
[FIX] Composer: pressing enter in the link editor
c07704c 
Previously, pressing Enter in the link editor would inadvertently open
the grid composer in edit mode, which was not the expected behavior.
This commit addresses the issue by adding a check in the onInput method
of the composer component.

Taskid: 3796114
X-original-commit: cbd04c9
@robodoo
Copy link
Collaborator

robodoo commented Apr 10, 2024

Pull request status dashboard.

@fw-bot
Copy link
Collaborator Author

fw-bot commented Apr 10, 2024

This PR targets 17.0 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@fw-bot fw-bot mentioned this pull request Apr 11, 2024
Closed
14 tasks
@dhrp-odoo
Copy link
Contributor

@fw-bot r+

@robodoo robodoo closed this in d93b6bc Apr 12, 2024
@fw-bot fw-bot deleted the 17.0-16.0-fix-link-editor-enter-dhrp-gPD_-fw branch April 26, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
forwardport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fw-bot @robodoo @dhrp-odoo