[FIX] Composer: pressing enter in the link editor #3931
Conversation
| @@ -364,6 +364,9 @@ export class Composer extends Component<ComposerProps, SpreadsheetChildEnv> { | |||
| const el = this.composerRef.el! as HTMLInputElement; | |||
| content = el.childNodes.length ? el.textContent! : ""; | |||
| } | |||
| if (!content && this.props.focus === "inactive") { | |||
There was a problem hiding this comment.
This probably works, but I think we should focus on the underlying cause of the issue: why the hell does the composer receive an input event when pressing enter on the link editor ?
There was a problem hiding this comment.
I think it's kind of the same beahaviour with the click event. When you mousedown and and mouseup on differnet targets, the click event is
Worth looking into it at least
There was a problem hiding this comment.
After digging into it, I noticed that when we press enter in the link editor, it triggers the input event in the composer. According to the documentation, this doesn't quite match how the click event behaves.
I tried adding an onInput listener higher up in the hierarchy, like a spreadsheet component, and ran into the same problem. EventPhase tells us that it is happening in the target phase, not during bubbling or capturing.
I am unsure if this is the default behavior or not. Using PreventDefault stops it, but it's likely to cause other problems.
There was a problem hiding this comment.
I'd argue taht preventDefault is exactly what you are looking for. You want to stop the browser chain of events since it makes no sense to keep the "keyboard input event" behaviour once we closed (and destroyed) the input .
Previously, pressing Enter in the link editor would inadvertently open the grid composer in edit mode, which was not the expected behavior. This commit addresses the issue by adding a check in the onInput method of the composer component. TaskID: 3796114
dhrp-odoo
force-pushed
the
16.0-fix-link-editor-enter-dhrp
branch
from
23ea594
to
aba4a37
Compare
|
@robodoo r+ |
Previously, pressing Enter in the link editor would inadvertently open the grid composer in edit mode, which was not the expected behavior. This commit addresses the issue by adding a check in the onInput method of the composer component. closes #3931 Taskid: 3796114 Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
|
@dhrp-odoo @rrahir this pull request has forward-port PRs awaiting action (not merged or closed): |
1 similar comment
|
@dhrp-odoo @rrahir this pull request has forward-port PRs awaiting action (not merged or closed): |
|
@dhrp-odoo @rrahir this pull request has forward-port PRs awaiting action (not merged or closed): |
1 similar comment
|
@dhrp-odoo @rrahir this pull request has forward-port PRs awaiting action (not merged or closed): |
Description:
Previously, pressing Enter in the link editor would inadvertently open the grid composer in edit mode, which was not the expected behavior. This PR addresses the issue by adding a check in the onInput method of the composer component.
Task: : 3796114
review checklist