[FW][FIX] Composer: pressing enter in the link editor #4034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets saas-17.2 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@dhrp-odoo @rrahir ci/runbot failed on this forward-port PR |
Previously, pressing Enter in the link editor would inadvertently open the grid composer in edit mode, which was not the expected behavior. This commit addresses the issue by adding a check in the onInput method of the composer component. Taskid: 3796114 X-original-commit: cbd04c9
dhrp-odoo
force-pushed
the
saas-17.2-16.0-fix-link-editor-enter-dhrp-beRr-fw
branch
from
a659f2c
to
d2f2091
Compare
|
@dhrp-odoo @rrahir this PR was modified / updated and has become a normal PR. It should be merged the normal way (via @robodoo) |
14 tasks
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Apr 10, 2024
Previously, pressing Enter in the link editor would inadvertently open the grid composer in edit mode, which was not the expected behavior. This commit addresses the issue by adding a check in the onInput method of the composer component. closes #4034 Taskid: 3796114 X-original-commit: cbd04c9 Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Previously, pressing Enter in the link editor would inadvertently open the grid composer in edit mode, which was not the expected behavior. This PR addresses the issue by adding a check in the onInput method of the composer component.
Task: : 3796114
review checklist
Forward-Port-Of: #4009
Forward-Port-Of: #3931