Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FW][FIX] data_validation: prevent icon overlap #4150

Closed
wants to merge 2 commits into from
Closed

[FW][FIX] data_validation: prevent icon overlap #4150

wants to merge 2 commits into from

Commits on Apr 29, 2024

  1. [MOV] filter_icon_overlay: move tests to correct folder 

    Task: 3684182
X-original-commit: 68ce808
    @hokolomopo
    hokolomopo committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    bacb031 View commit details
    Browse the repository at this point in the history

  2. [FIX] data_validation: prevent icon overlap 

    A same cell could have a data validation icon and a filter icon at
the same time, possibly causing overlap.

This commit disable the data validation icons on cells that have a
filter icon.

Note: for future work (in master), it'd be nice if we could create
a generic way to display a grid icon that would ensure that there is
no two icons on the same cell, and not handle them on a case by case
basis.

Task: 3684182
X-original-commit: 60f9fdd
    @hokolomopo
    hokolomopo committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    3b5f68a View commit details
    Browse the repository at this point in the history