[FW][FIX] data_validation: prevent icon overlap #4150
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Task: 3684182 X-original-commit: 68ce808
A same cell could have a data validation icon and a filter icon at the same time, possibly causing overlap. This commit disable the data validation icons on cells that have a filter icon. Note: for future work (in master), it'd be nice if we could create a generic way to display a grid icon that would ensure that there is no two icons on the same cell, and not handle them on a case by case basis. Task: 3684182 X-original-commit: 60f9fdd
|
This PR targets saas-17.1 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@hokolomopo @pro-odoo the next pull request (#4151) is in conflict. You can merge the chain up to here by saying
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
fw-bot r+
…On Mon, Apr 29, 2024 at 11:28 AM Otis - Odoo Forward-Port Steward [bot] < ***@***.***> wrote:
@hokolomopo <https://github.com/hokolomopo> @pro-odoo
<https://github.com/pro-odoo> the next pull request (#4151
<#4151>) is in conflict. You
can merge the chain up to here by saying
@fw-bot <https://github.com/fw-bot> r+
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port
—
Reply to this email directly, view it on GitHub
<#4150 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHFIBHU4RQHUOIYLSY5C7NDY7YHDVAVCNFSM6AAAAABG56D2S6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBSGI3DMMBZHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
robodoo
pushed a commit
that referenced
this pull request
Apr 29, 2024
A same cell could have a data validation icon and a filter icon at the same time, possibly causing overlap. This commit disable the data validation icons on cells that have a filter icon. Note: for future work (in master), it'd be nice if we could create a generic way to display a grid icon that would ensure that there is no two icons on the same cell, and not handle them on a case by case basis. closes #4150 Task: 3684182 X-original-commit: 60f9fdd Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
fw-bot
deleted the
saas-17.1-17.0-data-validation-icon-filter-icon-adrm-cQ8p-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
A same cell could have a data validation icon and a filter icon at
the same time, possibly causing overlap.
This commit disable the data validation icons on cells that have a
filter icon.
Note: for future work (in master), it'd be nice if we could create
a generic way to display a grid icon that would ensure that there is
no two icons on the same cell, and not handle them on a case by case
basis.
Task: : 3684182
review checklist
Forward-Port-Of: #4085