Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[FIX] web: make sure onchanges are properly triggered
The issue adressed by this fix was observed by a problem with a missing onchange. The situation only happens when we have a one2many in a form view with an onchange in a field in the list view, and the arch of the list view is not inline. In that case, the onchange was not properly triggered. There are two causes for this bug: - the BasicModel does not exactly receive the same data when loading a record in a one2many with a non inline view. More specifically, there is a confusion with the fields/viewFields in that case. This is done because the postprocessing of the fields is slightly different when a sub view is not inline (not ideal situation, we should fix it btw) - when it construct a subrecord, the BasicModel did not use the correct fields value, when there was a subview. More specifically, it used the view.fields (which does not contain onchange informations) instead of the view.viewFields (which contains processed/view specific informations, including the onchange data. This commit fixes the second issue, because this is clearly a bug, and it actually fixes the problem. The first issue is actually okay, because we already have a difference of behaviour between the main view and sub views (in the first case, we have the fieldget information, not in the second case, so the processing is already a little bit different anyway) Notes: - This bug was discovered only because we added a test in 11.0, which was forwardported and broke in master. The breakage occured because of a recent refactoring in master which moved the arch processing inside the views and out of the data manager. - It is good that we discovered this bug, but I want to say that it really sucks that forwardports are done, break the master/saas.11.2, then I have to fix it in emergency, and it completely break my own schedule... wip wip
- Loading branch information