[FIX] base: ignore empty translatable attribute

Complete cd40808
  <span class="fa fa-globe" title="Title stuff"/>
is not correctly extracted but
  <span class="fa fa-globe" title=""/>
was also extracted while there is no content

Check the size of the content too

Similar content is present on odoo.com website and should not be translatable
on Transifex

closes #32018

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

odoo/addons/base/tests/test_translate.py

@@ -131,6 +131,19 @@ def test_translate_xml_inline4(self):
         self.assertItemsEqual(terms,
             ['Form stuff', '<span class="fa fa-globe" title="Title stuff"/>'])
 
+    def test_translate_xml_inline5(self):
+        """ Test xml_translate() with inline elements with empty translated attrs only. """
+        terms = []
+        source = """<form string="Form stuff">
+                        <div>
+                            <label for="stuff"/>
+                            <span class="fa fa-globe" title=""/>
+                        </div>
+                    </form>"""
+        result = xml_translate(terms.append, source)
+        self.assertEquals(result, source)
+        self.assertItemsEqual(terms, ['Form stuff'])
+
     def test_translate_xml_t(self):
         """ Test xml_translate() with t-* attributes. """
         terms = []

odoo/tools/translate.py

@@ -257,7 +257,7 @@ def process(node):
             result.tail = node.tail
             has_text = (
                 todo_has_text or nonspace(result.text) or nonspace(result.tail)
-                or any(name in TRANSLATED_ATTRS for name in result.attrib)
+                or any((key in TRANSLATED_ATTRS and val) for key, val in result.attrib.items())
             )
             return (has_text, result)