Skip to content

Commit

Permalink
[FIX] stock_account: fix sum list of dict
Browse files Browse the repository at this point in the history
This commit fixes summing list of dicts returned by
_prepare_analytic_lines.

closes #154907

Nb: This code is not yet covered by a test use case.
X-original-commit: 0e91af4
Signed-off-by: Cedric Snauwaert <csn@odoo.com>
  • Loading branch information
tli-asl committed Feb 23, 2024
1 parent 22f30a4 commit 5194dd5
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions addons/stock_account/models/stock_move.py
Expand Up @@ -425,8 +425,8 @@ def _prepare_analytic_lines(self):
account_valuation = accounts_data.get('stock_valuation', False)
analytic_line_vals = self.stock_valuation_layer_ids.account_move_id.line_ids.filtered(
lambda l: l.account_id == account_valuation)._prepare_analytic_lines()
amount = - sum(sum(vals['amount'] for vals in lists) for lists in analytic_line_vals)
unit_amount = - sum(sum(vals['unit_amount'] for vals in lists) for lists in analytic_line_vals)
amount = - sum(vals['amount'] for vals in analytic_line_vals)
unit_amount = - sum(vals['unit_amount'] for vals in analytic_line_vals)
elif sum(self.stock_valuation_layer_ids.mapped('quantity')):
amount = sum(self.stock_valuation_layer_ids.mapped('value'))
unit_amount = - sum(self.stock_valuation_layer_ids.mapped('quantity'))
Expand Down

0 comments on commit 5194dd5

Please sign in to comment.