Skip to content

Commit

Permalink
[FIX] web: remove report_assets_common JS from minimal_layout
Browse files Browse the repository at this point in the history
This assets has a lot of JS that is loaded by wkhtmltopdf without any reasons.
Wkhtmltopdf don't like long js to load (it is why subst has been write inline)

This commit allow to print again (on slowly server) several documents in the
same pdf. Before this commit, the JS was not loaded before the default js-delay
and so the subst function never called with as result a pdf of only 1 page.

After this commit you can again print several documents in the same pdf and
subst function is applied.

opw-1909000

courtesy of @beledouxdenis that help to debug this error since it is only
reproductible on paas server.

This commit follow the same logic that commit 3c61ee5
And issue wkhtmltopdf/wkhtmltopdf#2083 is not yet fixed
  • Loading branch information
JKE-be committed Dec 7, 2018
1 parent 37fa21a commit 8a05ad7
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion addons/web/views/report_templates.xml
Expand Up @@ -102,7 +102,6 @@
<t t-call-assets="web.report_assets_pdf" t-js="false"/>
<t t-call-assets="web.report_assets_common" t-js="false"/>
<t t-call-assets="web.report_assets_pdf" t-css="false"/>
<t t-call-assets="web.report_assets_common" t-css="false"/>
<meta charset="utf-8"/>
<t t-if="subst is True">
<script>
Expand Down

0 comments on commit 8a05ad7

Please sign in to comment.