Skip to content

Commit

Permalink
[REM] *: remove useless 'group_by_no_leaf' context key
Browse files Browse the repository at this point in the history
As of #110737, 'group_by_no_leaf' is
no longer used. Previously it was used to change the name of the
'__count' aggregate of read_group() but had no effect anywhere (and the
webclient just didn't care).

Remove this remnant.

closes #147735

Related: odoo/enterprise#53488
Signed-off-by: Raphael Collet <rco@odoo.com>
  • Loading branch information
ryv-odoo committed Jan 16, 2024
1 parent 3c1466f commit bb16417
Show file tree
Hide file tree
Showing 16 changed files with 19 additions and 82 deletions.
4 changes: 2 additions & 2 deletions addons/account/report/account_invoice_report_view.xml
Expand Up @@ -132,15 +132,15 @@
<field name="name">Invoices Analysis</field>
<field name="res_model">account.invoice.report</field>
<field name="view_mode">graph,pivot</field>
<field name="context">{'search_default_current':1, 'search_default_supplier': 1, 'group_by':['invoice_date:month'], 'group_by_no_leaf':1}</field>
<field name="context">{'search_default_current':1, 'search_default_supplier': 1, 'group_by':['invoice_date:month']}</field>
<field name="search_view_id" ref="view_account_invoice_report_search"/>
<field name="help">From this report, you can have an overview of the amount invoiced from your vendors. The search tool can also be used to personalise your Invoices reports and so, match this analysis to your needs.</field>
</record>
<record id="action_account_invoice_report_all" model="ir.actions.act_window">
<field name="name">Invoices Analysis</field>
<field name="res_model">account.invoice.report</field>
<field name="view_mode">graph,pivot</field>
<field name="context">{'search_default_current':1, 'search_default_customer': 1, 'group_by':['invoice_date:month'], 'group_by_no_leaf':1}</field>
<field name="context">{'search_default_current':1, 'search_default_customer': 1, 'group_by':['invoice_date:month']}</field>
<field name="search_view_id" ref="view_account_invoice_report_search"/>
<field name="help">From this report, you can have an overview of the amount invoiced to your customers. The search tool can also be used to personalise your Invoices reports and so, match this analysis to your needs.</field>
</record>
Expand Down
2 changes: 1 addition & 1 deletion addons/membership/report/report_membership_views.xml
Expand Up @@ -83,7 +83,7 @@
<field name="res_model">report.membership</field>
<field name="view_mode">graph,pivot</field>
<field name="search_view_id" ref="view_report_membership_search"/>
<field name="context">{"search_default_start_date":1,"search_default_member":1, 'search_default_Revenue':1, 'search_default_this_month':1, 'search_default_salesman':1,'group_by_no_leaf':1}</field>
<field name="context">{"search_default_start_date":1,"search_default_member":1, 'search_default_Revenue':1, 'search_default_this_month':1, 'search_default_salesman':1}</field>
<field name="help" type="html">
<p class="o_view_nocontent_smiling_face">
No data yet!
Expand Down
2 changes: 1 addition & 1 deletion addons/point_of_sale/views/pos_order_report_view.xml
Expand Up @@ -82,7 +82,7 @@
<field name="res_model">report.pos.order</field>
<field name="view_mode">graph,pivot</field>
<field name="search_view_id" ref="view_report_pos_order_search"/>
<field name="context">{'group_by_no_leaf':1,'group_by':[]}</field>
<field name="context">{'group_by':[]}</field>
<field name="help" type="html">
<p class="o_view_nocontent_smiling_face">
No data yet!
Expand Down
2 changes: 1 addition & 1 deletion addons/project/report/project_report_views.xml
Expand Up @@ -45,7 +45,7 @@
<field name="res_model">report.project.task.user</field>
<field name="view_mode">graph,pivot</field>
<field name="search_view_id" ref="view_task_project_user_search"/>
<field name="context">{'group_by_no_leaf':1, 'group_by':[], 'graph_measure': '__count__'}</field>
<field name="context">{'group_by':[], 'graph_measure': '__count__'}</field>
<field name="help" type="html">
<p class="o_view_nocontent_empty_folder">
No data yet!
Expand Down
4 changes: 2 additions & 2 deletions addons/sale/report/sale_report_views.xml
Expand Up @@ -126,7 +126,7 @@
<field name="view_id"></field> <!-- force empty -->
<field name="search_view_id" ref="view_order_product_search"/>
<field name="domain">[('state', '!=', 'cancel')]</field>
<field name="context">{'search_default_Sales':1, 'group_by_no_leaf':1,'group_by':[], 'search_default_filter_order_date': 1}</field>
<field name="context">{'search_default_Sales':1,'group_by':[], 'search_default_filter_order_date': 1}</field>
<field name="help">This report performs analysis on your quotations and sales orders. Analysis check your sales revenues and sort it by different group criteria (salesman, partner, product, etc.) Use this report to perform analysis on sales not having invoiced yet. If you want to analyse your turnover, you should use the Invoice Analysis report in the Accounting application.</field>
</record>

Expand All @@ -146,7 +146,7 @@
<field name="view_mode">graph,pivot</field>
<field name="view_id" ref="sale_report_graph_pie"/>
<field name="search_view_id" ref="view_order_product_search"/>
<field name="context">{'search_default_Sales': 1, 'search_default_Product': 1, 'group_by_no_leaf':1, 'group_by': 'product_id', 'search_default_filter_order_date': 1}</field>
<field name="context">{'search_default_Sales': 1, 'search_default_Product': 1, 'group_by': 'product_id', 'search_default_filter_order_date': 1}</field>
<field name="help">This report performs analysis on your quotations and sales orders. Analysis check your sales revenues and sort it by different group criteria (salesman, partner, product, etc.) Use this report to perform analysis on sales not having invoiced yet. If you want to analyse your turnover, you should use the Invoice Analysis report in the Accounting application.</field>
</record>

Expand Down
2 changes: 1 addition & 1 deletion addons/sale_project/views/project_task_views.xml
Expand Up @@ -14,7 +14,7 @@
</record>

<record id="project.action_project_task_user_tree" model="ir.actions.act_window">
<field name="context">{'group_by_no_leaf':1, 'group_by':[], 'graph_measure': '__count__', 'sale_show_partner_name': True}</field>
<field name="context">{'group_by':[], 'graph_measure': '__count__', 'sale_show_partner_name': True}</field>
</record>

<record id="project_project_view_inherit_project_filter" model="ir.ui.view">
Expand Down
Expand Up @@ -1237,8 +1237,7 @@
"context": {
"group_by": [
"invoice_date"
],
"group_by_no_leaf": 1
]
},
"domain": [
"&",
Expand Down Expand Up @@ -1606,8 +1605,7 @@
"context": {
"group_by": [
"invoice_date"
],
"group_by_no_leaf": 1
]
},
"domain": [
"&",
Expand Down Expand Up @@ -1656,8 +1654,7 @@
"context": {
"group_by": [
"invoice_date"
],
"group_by_no_leaf": 1
]
},
"domain": [
"&",
Expand Down Expand Up @@ -1706,8 +1703,7 @@
"context": {
"group_by": [
"invoice_date"
],
"group_by_no_leaf": 1
]
},
"domain": [
"&",
Expand Down Expand Up @@ -1756,8 +1752,7 @@
"context": {
"group_by": [
"invoice_date"
],
"group_by_no_leaf": 1
]
},
"domain": [
"&",
Expand Down Expand Up @@ -1806,8 +1801,7 @@
"context": {
"group_by": [
"invoice_date"
],
"group_by_no_leaf": 1
]
},
"domain": [
"&",
Expand Down Expand Up @@ -1847,8 +1841,7 @@
"context": {
"group_by": [
"invoice_date"
],
"group_by_no_leaf": 1
]
},
"domain": [
"&",
Expand Down Expand Up @@ -1891,8 +1884,7 @@
"context": {
"group_by": [
"invoice_date"
],
"group_by_no_leaf": 1
]
},
"domain": [
"&",
Expand Down
Expand Up @@ -741,7 +741,6 @@
"searchParams": {
"comparison": null,
"context": {
"group_by_no_leaf": 1,
"group_by": [],
"graph_measure": "__count__"
},
Expand Down Expand Up @@ -780,7 +779,6 @@
"searchParams": {
"comparison": null,
"context": {
"group_by_no_leaf": 1,
"group_by": [],
"graph_measure": "__count__"
},
Expand Down Expand Up @@ -1075,7 +1073,6 @@
"1": {
"colGroupBys": [],
"context": {
"group_by_no_leaf": 1,
"group_by": [],
"graph_measure": "__count__"
},
Expand Down Expand Up @@ -1112,7 +1109,6 @@
"2": {
"colGroupBys": [],
"context": {
"group_by_no_leaf": 1,
"group_by": [],
"graph_measure": "__count__"
},
Expand Down Expand Up @@ -1149,7 +1145,6 @@
"3": {
"colGroupBys": [],
"context": {
"group_by_no_leaf": 1,
"group_by": [],
"graph_measure": "__count__"
},
Expand Down Expand Up @@ -1186,7 +1181,6 @@
"4": {
"colGroupBys": [],
"context": {
"group_by_no_leaf": 1,
"group_by": [],
"graph_measure": "__count__"
},
Expand Down Expand Up @@ -1223,7 +1217,6 @@
"5": {
"colGroupBys": [],
"context": {
"group_by_no_leaf": 1,
"group_by": [],
"graph_measure": "__count__"
},
Expand Down Expand Up @@ -1258,7 +1251,6 @@
"6": {
"colGroupBys": [],
"context": {
"group_by_no_leaf": 1,
"group_by": [],
"graph_measure": "__count__"
},
Expand Down
Expand Up @@ -1096,7 +1096,6 @@
"searchParams": {
"comparison": null,
"context": {
"group_by_no_leaf": 1,
"group_by": []
},
"domain": [["state", "in", ["paid", "done", "invoiced"]]],
Expand Down Expand Up @@ -1327,7 +1326,6 @@
"1": {
"colGroupBys": [],
"context": {
"group_by_no_leaf": 1,
"group_by": []
},
"domain": [["state", "in", ["paid", "done", "invoiced"]]],
Expand Down Expand Up @@ -1357,7 +1355,6 @@
"2": {
"colGroupBys": [],
"context": {
"group_by_no_leaf": 1,
"group_by": []
},
"domain": [["state", "in", ["paid", "done", "invoiced"]]],
Expand Down Expand Up @@ -1387,7 +1384,6 @@
"3": {
"colGroupBys": [],
"context": {
"group_by_no_leaf": 1,
"group_by": []
},
"domain": [
Expand Down Expand Up @@ -1424,7 +1420,6 @@
"4": {
"colGroupBys": [],
"context": {
"group_by_no_leaf": 1,
"group_by": []
},
"domain": [
Expand Down Expand Up @@ -1461,7 +1456,6 @@
"5": {
"colGroupBys": [],
"context": {
"group_by_no_leaf": 1,
"group_by": []
},
"domain": [["state", "in", ["paid", "done", "invoiced"]]],
Expand All @@ -1482,7 +1476,6 @@
"6": {
"colGroupBys": [],
"context": {
"group_by_no_leaf": 1,
"group_by": []
},
"domain": [["state", "in", ["paid", "done", "invoiced"]]],
Expand Down
Expand Up @@ -471,7 +471,6 @@
"searchParams": {
"comparison": null,
"context": {
"group_by_no_leaf": 1,
"group_by": []
},
"domain": [[
Expand Down Expand Up @@ -515,7 +514,6 @@
"searchParams": {
"comparison": null,
"context": {
"group_by_no_leaf": 1,
"group_by": []
},
"domain": [[
Expand Down Expand Up @@ -724,7 +722,6 @@
"1": {
"colGroupBys": [],
"context": {
"group_by_no_leaf": 1,
"group_by": []
},
"domain": [[
Expand Down Expand Up @@ -765,7 +762,6 @@
"2": {
"colGroupBys": [],
"context": {
"group_by_no_leaf": 1,
"group_by": []
},
"domain": [[
Expand Down
Expand Up @@ -1954,7 +1954,6 @@
"searchParams": {
"comparison": null,
"context": {
"group_by_no_leaf": 1,
"group_by": []
},
"domain": [
Expand Down Expand Up @@ -2380,7 +2379,6 @@
"menu_id": 878,
"cids": 1
},
"group_by_no_leaf": 1,
"group_by": []
},
"domain": [
Expand Down Expand Up @@ -2431,7 +2429,6 @@
"menu_id": 878,
"cids": 1
},
"group_by_no_leaf": 1,
"group_by": []
},
"domain": [
Expand Down Expand Up @@ -2482,7 +2479,6 @@
"menu_id": 878,
"cids": 1
},
"group_by_no_leaf": 1,
"group_by": []
},
"domain": [
Expand Down Expand Up @@ -2533,7 +2529,6 @@
"menu_id": 878,
"cids": 1
},
"group_by_no_leaf": 1,
"group_by": []
},
"domain": [
Expand Down Expand Up @@ -2577,7 +2572,6 @@
"7": {
"colGroupBys": [],
"context": {
"group_by_no_leaf": 1,
"group_by": []
},
"domain": [
Expand Down Expand Up @@ -2621,7 +2615,6 @@
"8": {
"colGroupBys": [],
"context": {
"group_by_no_leaf": 1,
"group_by": []
},
"domain": [
Expand Down Expand Up @@ -2665,7 +2658,6 @@
"9": {
"colGroupBys": [],
"context": {
"group_by_no_leaf": 1,
"group_by": []
},
"domain": [
Expand Down Expand Up @@ -2709,7 +2701,6 @@
"10": {
"colGroupBys": [],
"context": {
"group_by_no_leaf": 1,
"group_by": []
},
"domain": [
Expand Down
Expand Up @@ -530,7 +530,6 @@
"comparison": null,
"context": {
"search_default_Sales": 1,
"group_by_no_leaf": 1,
"group_by": [],
"search_default_filter_order_date": 1,
"search_default_recurring": 0,
Expand Down Expand Up @@ -804,7 +803,6 @@
"colGroupBys": [],
"context": {
"search_default_Sales": 1,
"group_by_no_leaf": 1,
"group_by": [],
"search_default_filter_order_date": 1,
"search_default_recurring": 0,
Expand Down

0 comments on commit bb16417

Please sign in to comment.