[IMP] delivery: don't open wizard when no carrier or based on rule or…

… fixed. Doesn't really work, maybe because of new views, to test.
odoo · Apr 28, 2017 · bddc4eb · bddc4eb
1 parent 0258511
commit bddc4eb
Showing 1 changed file with 16 additions and 13 deletions.
diff --git a/addons/delivery/models/stock_picking.py b/addons/delivery/models/stock_picking.py
@@ -31,7 +31,7 @@ class StockPackOperation(models.Model):
     @api.multi
     def manage_package_type(self):
         self.ensure_one()
-        view_id = self.env.ref('delivery.choose_delivery_package_view_form').id;
+        view_id = self.env.ref('delivery.choose_delivery_package_view_form').id
         return {
             'name': _('Package Details'),
             'type': 'ir.actions.act_window',
@@ -123,19 +123,22 @@ def do_transfer(self):
 
     @api.multi
     def put_in_pack(self):
-        view_id = self.env.ref('delivery.choose_delivery_package_view_form').id;
-        return {
-            'name': _('Package Details'),
-            'type': 'ir.actions.act_window',
-            'view_mode': 'form',
-            'res_model': 'choose.delivery.package',
-            'view_id': view_id,
-            'views': [(view_id, 'form')],
-            'target': 'new',
-            'context': {
-                'current_package_carrier_type': self.carrier_id.delivery_type if self.carrier_id.delivery_type not in ['base_on_rule', 'fixed'] else 'none',
+        if self.carrier_id and self.carrier_id.delivery_type not in ['base_on_rule', 'fixed']:
+            view_id = self.env.ref('delivery.choose_delivery_package_view_form').id
+            return {
+                'name': _('Package Details'),
+                'type': 'ir.actions.act_window',
+                'view_mode': 'form',
+                'res_model': 'choose.delivery.package',
+                'view_id': view_id,
+                'views': [(view_id, 'form')],
+                'target': 'new',
+                'context': {
+                    'current_package_carrier_type': self.carrier_id.delivery_type,
+                }
             }
-        }
+        else:
+            return self._put_in_pack()
 
     @api.multi
     def send_to_shipper(self):