Skip to content

Commit

Permalink
[IMP] project_timesheet_holidays: change test class
Browse files Browse the repository at this point in the history
We try to define common classes in test with helpers to
set testing data. Here, we had a test extended a class
with test methods, making those tests executed twice:
when hr_timesheet was installed, and on project_timesheet_holidays
installation.
This is not very stable, as some behavior might change when
other are installed.

closes #29538
  • Loading branch information
jem-odoo committed Dec 13, 2018
1 parent 1cb506c commit c33ac77
Showing 1 changed file with 2 additions and 2 deletions.
Expand Up @@ -7,7 +7,7 @@
from odoo import fields

from odoo.tests import common
from odoo.addons.hr_timesheet.tests.test_timesheet import TestTimesheet
from odoo.addons.hr_timesheet.tests.test_timesheet import TestCommonTimesheet


class TestTimesheetHolidaysCreate(common.TransactionCase):
Expand All @@ -24,7 +24,7 @@ def test_status_create(self):
self.assertEqual(status.timesheet_task_id, company.leave_timesheet_task_id, 'The default task linked to the status should be the same as the company')


class TestTimesheetHolidays(TestTimesheet):
class TestTimesheetHolidays(TestCommonTimesheet):

def setUp(self):
super(TestTimesheetHolidays, self).setUp()
Expand Down

0 comments on commit c33ac77

Please sign in to comment.