[FIX] membership: infinite recursion in computed fields

closes #38050

X-original-commit: 1b50c05
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

addons/membership/models/partner.py

@@ -86,12 +86,9 @@ def _compute_membership_stop(self):
                  'associate_member.membership_state')
     def _compute_membership_cancel(self):
         for partner in self:
-            if partner.membership_state == 'canceled':
-                partner.membership_cancel = self.env['membership.membership_line'].search([
-                    ('partner', '=', partner.id)
-                ], limit=1, order='date_cancel').date_cancel
-            else:
-                partner.membership_cancel = False
+            partner.membership_cancel = self.env['membership.membership_line'].search([
+                ('partner', '=', partner.id)
+            ], limit=1, order='date_cancel desc').date_cancel
 
     def _membership_state(self):
         """This Function return Membership State For Given Partner. """