Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.0E] Flanker not found, missing Python library in requirements #11870

Closed
Yenthe666 opened this issue Apr 30, 2016 · 5 comments
Closed

[9.0E] Flanker not found, missing Python library in requirements #11870

Yenthe666 opened this issue Apr 30, 2016 · 5 comments

Comments

@Yenthe666
Copy link
Collaborator

Impacted versions: 9.0 Enterprise

Steps to reproduce: Install a new Odoo V9 Enterprise and install the module website_crm_score.
Check the logfile afterwards:
2016-04-30 11:06:53,802 2605 WARNING ? openerp.addons.website_crm_score.models.sales_team: flanker not found, email validation disabled.

Current behavior:
Warnings in the Odoo logfile when Flanker is not installed

Expected behavior:
Flanker should be either added as a requirement on requirements.txt or it should be automatically installed on the system when you install the module website_crm_score?
Either way, there is no way for the system administrator to know that this Python package should be installed and it is not mentioned anywhere.

@Yenthe666
Copy link
Collaborator Author

@mart-e I think you might know this. Is it by purpose not in the requirements.txt since it is only used in enterprise or?

@mart-e
Copy link
Contributor

mart-e commented May 2, 2016

This is not an mandatory dependency, the module will still work without this, just the verification of email addresses that will not be present.
We have a few of those, as it is very specific (webiste_crm_score is quite advanced, requires complex configuration), we don't want to impose it to everyone.

So no, I don't think it should go in requirement.
We could add information about this in the description of the module though.

@Yenthe666
Copy link
Collaborator Author

Alright so it does make sense that it is not a requirement but, honestly, without opening the logfiles you would never know you'd need it.
I think it would be a good idea to add it in the description of the module and also on the documentation later on.
Perhaps a little warning could be thrown up in Odoo too? On the moment you install the module or something. Just a simple dialog.

@mart-e
Copy link
Contributor

mart-e commented May 2, 2016

PR welcome 😉
I am not fan of popup warning (because people seeing the popup are probably not necessary the people that can do something about the problem) but sure, we can put it in the description of the module.

@JKE-be
Copy link
Contributor

JKE-be commented May 10, 2016

duplicate of #11840

@JKE-be JKE-be closed this as completed May 10, 2016
bouvyd pushed a commit to odoo-dev/odoo that referenced this issue Nov 27, 2017
…talled

The warning was raised as soons as the module was loaded (always because the
module has static folder) even if website_crm_score was not installed.

Now we launch the warning only when we use the function check_mail.

Related: odoo#11840 odoo#11870
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants