Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dependency for xlwt in RPM package #12897

Closed
yajo opened this issue Jul 25, 2016 · 5 comments
Closed

Missing dependency for xlwt in RPM package #12897

yajo opened this issue Jul 25, 2016 · 5 comments

Comments

@yajo
Copy link
Contributor

yajo commented Jul 25, 2016

Impacted versions: 8.0

Steps to reproduce: install RPM package, open python console, execute import xlwt

Current behavior: ImportError

Expected behavior: works.

Video/Screenshot link (optional):

@yajo
Copy link
Contributor Author

yajo commented Jul 25, 2016

@kutyel this was the bug you hit last week, fixed in https://bitbucket.org/yajo/docker-odoo/commits/4694dcf323bd222549118a3a9f66955977665094. Repull image and it will work (after rebuilt).

@mart-e
Copy link
Contributor

mart-e commented Jul 25, 2016

Hello,

xlwt is an optional dependency and Odoo should not crash if you don't have installed (we have some checks to verify if the module is present or not.
However for consistency (it is included in the deb package), it would make sense to add it also in rpm.
If you have a patch for master, would gladly accept it.

@yajo
Copy link
Contributor Author

yajo commented Jul 25, 2016

xlwt comes in the v9 RPM AFAIK, maybe just backport that commit (wherever it is), not?

@mart-e
Copy link
Contributor

mart-e commented Jul 25, 2016

Oh sorry I missed your issue was for 8.0 but anyway, if Odoo do work without xlwt (no error during use, all Excel-related options are hidden), I want to avoid changing the packaging. It would be an improvement, not a bug fix.
If you have a scenario where it doesn't work, ok to backport.

In the code we have at several places

try:
    import xlwt
except ImportError:
    xlwt = None

yajo added a commit to Tecnativa/reporting-engine that referenced this issue Jul 25, 2016
Given `xlwt` could happen to not be installed because it is an optional dependency.

See odoo/odoo#12897 (comment).
@yajo
Copy link
Contributor Author

yajo commented Jul 25, 2016

OK no problem, fixing downstream at OCA/reporting-engine#62

@yajo yajo closed this as completed Jul 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants