Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid method signature in sale.order (R16) #162742

Closed
jerzyk opened this issue Apr 20, 2024 · 2 comments
Closed

invalid method signature in sale.order (R16) #162742

jerzyk opened this issue Apr 20, 2024 · 2 comments
Labels
16.0 Marketing CRM, mail, event, livechat, mass mailing, online appointments, ...

Comments

@jerzyk
Copy link
Contributor

jerzyk commented Apr 20, 2024

Impacted versions:
16.0

method _notify_by_email_prepare_rendering_context in addons/sale/models/sale_order.py

has msg_vals without default value, but method signature has it (and was changed in 3eb9680)

@Feyensv Feyensv added Marketing CRM, mail, event, livechat, mass mailing, online appointments, ... 16.0 labels Apr 22, 2024
@Feyensv
Copy link
Contributor

Feyensv commented Apr 22, 2024

cc: @tde-banana-odoo
Is it an issue if some overrides do not handle the case where msg_vals is not given ? (at least sale, purchase & account overrides AFAICS)

@tde-banana-odoo
Copy link
Contributor

Don't know, easy to fix anyway ...

Feyensv added a commit to odoo-dev/odoo that referenced this issue Apr 25, 2024
Since 3eb9680, the signature of method
`_notify_by_email_prepare_rendering_context` has been changed to provide
a default values to `msg_vals` and some overrides were not adapted
(or have been added afterwards).

No true bug/issue has been found caused by that discrepancy, but for
consistency, this commit makes sure those overrides are adapted to
provide the same API as the parent method.

Fixes odoo#162742
robodoo pushed a commit that referenced this issue Apr 25, 2024
Since 3eb9680, the signature of method
`_notify_by_email_prepare_rendering_context` has been changed to provide
a default values to `msg_vals` and some overrides were not adapted
(or have been added afterwards).

No true bug/issue has been found caused by that discrepancy, but for
consistency, this commit makes sure those overrides are adapted to
provide the same API as the parent method.

Fixes #162742

closes #163334

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
fw-bot pushed a commit to odoo-dev/odoo that referenced this issue Apr 25, 2024
Since 3eb9680, the signature of method
`_notify_by_email_prepare_rendering_context` has been changed to provide
a default values to `msg_vals` and some overrides were not adapted
(or have been added afterwards).

No true bug/issue has been found caused by that discrepancy, but for
consistency, this commit makes sure those overrides are adapted to
provide the same API as the parent method.

Fixes odoo#162742

X-original-commit: d4b3184
fw-bot pushed a commit to odoo-dev/odoo that referenced this issue Apr 25, 2024
Since 3eb9680, the signature of method
`_notify_by_email_prepare_rendering_context` has been changed to provide
a default values to `msg_vals` and some overrides were not adapted
(or have been added afterwards).

No true bug/issue has been found caused by that discrepancy, but for
consistency, this commit makes sure those overrides are adapted to
provide the same API as the parent method.

Fixes odoo#162742

X-original-commit: d4b3184
fw-bot pushed a commit to odoo-dev/odoo that referenced this issue Apr 25, 2024
Since 3eb9680, the signature of method
`_notify_by_email_prepare_rendering_context` has been changed to provide
a default values to `msg_vals` and some overrides were not adapted
(or have been added afterwards).

No true bug/issue has been found caused by that discrepancy, but for
consistency, this commit makes sure those overrides are adapted to
provide the same API as the parent method.

Fixes odoo#162742

X-original-commit: d4b3184
fw-bot pushed a commit to odoo-dev/odoo that referenced this issue Apr 25, 2024
Since 3eb9680, the signature of method
`_notify_by_email_prepare_rendering_context` has been changed to provide
a default values to `msg_vals` and some overrides were not adapted
(or have been added afterwards).

No true bug/issue has been found caused by that discrepancy, but for
consistency, this commit makes sure those overrides are adapted to
provide the same API as the parent method.

Fixes odoo#162742

X-original-commit: d4b3184
fw-bot pushed a commit to odoo-dev/odoo that referenced this issue Apr 25, 2024
Since 3eb9680, the signature of method
`_notify_by_email_prepare_rendering_context` has been changed to provide
a default values to `msg_vals` and some overrides were not adapted
(or have been added afterwards).

No true bug/issue has been found caused by that discrepancy, but for
consistency, this commit makes sure those overrides are adapted to
provide the same API as the parent method.

Fixes odoo#162742

X-original-commit: d4b3184
fw-bot pushed a commit to odoo-dev/odoo that referenced this issue Apr 25, 2024
Since 3eb9680, the signature of method
`_notify_by_email_prepare_rendering_context` has been changed to provide
a default values to `msg_vals` and some overrides were not adapted
(or have been added afterwards).

No true bug/issue has been found caused by that discrepancy, but for
consistency, this commit makes sure those overrides are adapted to
provide the same API as the parent method.

Fixes odoo#162742

X-original-commit: d4b3184
robodoo pushed a commit that referenced this issue Apr 26, 2024
Since 3eb9680, the signature of method
`_notify_by_email_prepare_rendering_context` has been changed to provide
a default values to `msg_vals` and some overrides were not adapted
(or have been added afterwards).

No true bug/issue has been found caused by that discrepancy, but for
consistency, this commit makes sure those overrides are adapted to
provide the same API as the parent method.

Fixes #162742

closes #163384

X-original-commit: d4b3184
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
robodoo pushed a commit that referenced this issue Apr 26, 2024
Since 3eb9680, the signature of method
`_notify_by_email_prepare_rendering_context` has been changed to provide
a default values to `msg_vals` and some overrides were not adapted
(or have been added afterwards).

No true bug/issue has been found caused by that discrepancy, but for
consistency, this commit makes sure those overrides are adapted to
provide the same API as the parent method.

Fixes #162742

closes #163402

X-original-commit: d4b3184
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
robodoo pushed a commit that referenced this issue Apr 26, 2024
Since 3eb9680, the signature of method
`_notify_by_email_prepare_rendering_context` has been changed to provide
a default values to `msg_vals` and some overrides were not adapted
(or have been added afterwards).

No true bug/issue has been found caused by that discrepancy, but for
consistency, this commit makes sure those overrides are adapted to
provide the same API as the parent method.

Fixes #162742

closes #163454

X-original-commit: d4b3184
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
robodoo pushed a commit that referenced this issue Apr 26, 2024
Since 3eb9680, the signature of method
`_notify_by_email_prepare_rendering_context` has been changed to provide
a default values to `msg_vals` and some overrides were not adapted
(or have been added afterwards).

No true bug/issue has been found caused by that discrepancy, but for
consistency, this commit makes sure those overrides are adapted to
provide the same API as the parent method.

Fixes #162742

closes #163431

X-original-commit: d4b3184
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
robodoo pushed a commit that referenced this issue Apr 26, 2024
Since 3eb9680, the signature of method
`_notify_by_email_prepare_rendering_context` has been changed to provide
a default values to `msg_vals` and some overrides were not adapted
(or have been added afterwards).

No true bug/issue has been found caused by that discrepancy, but for
consistency, this commit makes sure those overrides are adapted to
provide the same API as the parent method.

Fixes #162742

closes #163443

X-original-commit: d4b3184
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
willylohws pushed a commit to willylohws/odoo that referenced this issue May 1, 2024
Since 3eb9680, the signature of method
`_notify_by_email_prepare_rendering_context` has been changed to provide
a default values to `msg_vals` and some overrides were not adapted
(or have been added afterwards).

No true bug/issue has been found caused by that discrepancy, but for
consistency, this commit makes sure those overrides are adapted to
provide the same API as the parent method.

Fixes odoo#162742

closes odoo#163418

X-original-commit: d4b3184
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
16.0 Marketing CRM, mail, event, livechat, mass mailing, online appointments, ...
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants