Translation broken when html/xml removed

[nhomar]

Impacted versions:

saas-11.5

Steps to reproduce:

example: Install spanish and then swich your user to spanish, try to open Account main menu with just account_accountant installed.

Current behavior:

Traceback.

Expected behavior:

No traceback.

solution

We actually conrrected the transifex text with the erroneous element but some things pops out here:

1. An html string is sent to transifex which is not correct in the context of send just the text part.
2. No checking such translations that should comply with the original structure are bringing back again the problem we had when we allow placehold things into the string.

cc @mart-e thanks.

[moylop260]

FYI I just ran the following command in order to find other similar cases:

pip install translate-toolkit
pofilter --test=xmltags ~/odoo_git/addons/account/i18n/es.po

The output was:

...

#: model_terms:ir.ui.view,arch_db:account.portal_invoice_page
msgid "<i class=\"fa fa-download\"/> Download"
msgstr "Descargar"

#: model_terms:ir.ui.view,arch_db:account.view_account_journal_form
msgid ""
"<i class=\"fa fa-fw o_button_icon fa-arrow-right\"/> Configure Email Servers"
msgstr "Configurar servidores de email"

#: model_terms:ir.ui.view,arch_db:account.invoice_form
msgid ""
"<span class=\"o_form_label\" attrs=\"{'invisible': "
"['|',('state','=','draft'), ('type','!=','out_refund')]}\">Credit "
"Note</span>"
msgstr "Nota de Crédito"

#: model_terms:ir.ui.view,arch_db:account.res_config_settings_view_form
msgid ""
"<span class=\"o_form_label\">Default Taxes</span>\n"
"                                    <span class=\"fa fa-lg fa-building-o\" title=\"Values set here are company-specific.\" aria-label=\"Values set here are company-specific.\" groups=\"base.group_multi_company\" role=\"img\"/>"
msgstr "Impuestos por defecto"

#: model_terms:ir.ui.view,arch_db:account.res_config_settings_view_form
msgid ""
"<span class=\"o_form_label\">Main Currency</span>\n"
"                                    <span class=\"fa fa-lg fa-building-o\" title=\"Values set here are company-specific.\" aria-label=\"Values set here are company-specific.\" groups=\"base.group_multi_company\" role=\"img\"/>"
msgstr "Moneda Principal"

#: model_terms:ir.ui.view,arch_db:account.account_journal_dashboard_kanban_view
msgid "<span name=\"button_import_placeholder\"/> Statements"
msgstr "Una cuenta bancaria puede pertenecer a un solo diario."

#: model_terms:ir.ui.view,arch_db:account.account_journal_dashboard_kanban_view
msgid "<span role=\"separator\">View</span>"
msgstr "Vista"

...

The groups parameter and another technical stuffs are added to translate them.

[moylop260]

Is not a regression of #14497?

[mart-e]

Hello,

Does this issue is still valid? As I understand, it is a problem of bad translations that needs to be fixed on Transifex but not really on Odoo side.
I did not know the --test=xmltags, thanks for the share

[mart-e]

By the way, you can check #33220 where I add a check to detect bad translations