Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Date picker shows wrong direction for (previous month, next month ) in RTL direction #50090

Closed
RachidAlassir opened this issue Apr 24, 2020 · 4 comments
Closed

Date picker shows wrong direction for (previous month, next month ) in RTL direction #50090

RachidAlassir opened this issue Apr 24, 2020 · 4 comments
Labels
13.0 Internationalization about translations

Comments

@RachidAlassir
Copy link
Contributor

Impacted versions: 13.0

Steps to reproduce: Change language that supports RTL direction, click at any field of type datetime.

Current behavior: buttons next month, previous month are not in right position.

Expected behavior: Change these two buttons while in RTL direction.

Video/Screenshot link (optional):
datepicker
@Yenthe666 Yenthe666 added the 13.0 label Apr 24, 2020
@Yenthe666
Copy link
Collaborator

@mart-e might be interesting for you (I was not sure which label & who to ping)

@RachidAlassir
Copy link
Contributor Author

@Yenthe666 Probably the "Internationalization" label.

@Yenthe666 Yenthe666 added the Internationalization about translations label Apr 28, 2020
@Yemeni
Copy link
Contributor

Yemeni commented Jun 21, 2020 •
edited

The issue is that the button gets rotates twice
I've done a quick fix to this to make it only rotate once
in Arabic RTL it will make it once now
I will push a pull request

image

@Yemeni Yemeni mentioned this issue Jun 21, 2020
Closed
@Yemeni
Copy link
Contributor

Yemeni commented Jun 21, 2020

You can pull the commit linked to this issue directly @RachidAlassir or wait until they merge the pull request

mart-e pushed a commit to Yemeni/odoo that referenced this issue Jul 23, 2020
@Yemeni @mart-e
[FIX] web: avoid double switching in RTL
26771bd 
The direction arrows in the datepicker were switched a first time in
fontawesome_overridden.scss

  .o_rtl
    ..fa-chevron-left,.fa-chevron-right
       transform: rotate(-180deg);

and a second time in datepicker.scss
  .o_rtl
     .bootstrap-datetimepicker-widget
        .prev,.next
	   transform: rotate(180deg);

The buttons were flipped twice

Signed the Odoo CLA

Fixes odoo#50090
Closes odoo#53369
fw-bot pushed a commit to odoo-dev/odoo that referenced this issue Jul 24, 2020
@Yemeni @mart-e
[FIX] web: avoid double switching in RTL
0c6c6e6 
The direction arrows in the datepicker were switched a first time in
fontawesome_overridden.scss

  .o_rtl
    ..fa-chevron-left,.fa-chevron-right
       transform: rotate(-180deg);

and a second time in datepicker.scss
  .o_rtl
     .bootstrap-datetimepicker-widget
        .prev,.next
	   transform: rotate(180deg);

The buttons were flipped twice

Signed the Odoo CLA

Fixes odoo#50090
Closes odoo#53369

X-original-commit: 8629fa3
@fw-bot fw-bot mentioned this issue Jul 24, 2020
Closed
fw-bot pushed a commit to odoo-dev/odoo that referenced this issue Jul 24, 2020
@Yemeni @mart-e
[FIX] web: avoid double switching in RTL
bb91199 
The direction arrows in the datepicker were switched a first time in
fontawesome_overridden.scss

  .o_rtl
    ..fa-chevron-left,.fa-chevron-right
       transform: rotate(-180deg);

and a second time in datepicker.scss
  .o_rtl
     .bootstrap-datetimepicker-widget
        .prev,.next
	   transform: rotate(180deg);

The buttons were flipped twice

Signed the Odoo CLA

Fixes odoo#50090
Closes odoo#53369

X-original-commit: 8629fa3
This was referenced Jul 24, 2020
Closed
Closed
mart-e pushed a commit to odoo-dev/odoo that referenced this issue Aug 4, 2020
@Yemeni @mart-e
[FIX] web: avoid double switching in RTL
406ea20 
The direction arrows in the datepicker were switched a first time in
fontawesome_overridden.scss

  .o_rtl
    ..fa-chevron-left,.fa-chevron-right
       transform: rotate(-180deg);

and a second time in datepicker.scss
  .o_rtl
     .bootstrap-datetimepicker-widget
        .prev,.next
	   transform: rotate(180deg);

The buttons were flipped twice

Signed the Odoo CLA

Fixes odoo#50090
Closes odoo#53369

X-original-commit: 8629fa3
robodoo pushed a commit that referenced this issue Aug 4, 2020
@Yemeni @mart-e
[FIX] web: avoid double switching in RTL
00048bd 
The direction arrows in the datepicker were switched a first time in
fontawesome_overridden.scss

  .o_rtl
    ..fa-chevron-left,.fa-chevron-right
       transform: rotate(-180deg);

and a second time in datepicker.scss
  .o_rtl
     .bootstrap-datetimepicker-widget
        .prev,.next
	   transform: rotate(180deg);

The buttons were flipped twice

Signed the Odoo CLA

Fixes #50090
Closes #53369

closes #54880

X-original-commit: 8629fa3
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
robodoo pushed a commit that referenced this issue Aug 4, 2020
@Yemeni @mart-e
[FIX] web: avoid double switching in RTL
05c439f 
The direction arrows in the datepicker were switched a first time in
fontawesome_overridden.scss

  .o_rtl
    ..fa-chevron-left,.fa-chevron-right
       transform: rotate(-180deg);

and a second time in datepicker.scss
  .o_rtl
     .bootstrap-datetimepicker-widget
        .prev,.next
	   transform: rotate(180deg);

The buttons were flipped twice

Signed the Odoo CLA

Fixes #50090
Closes #53369

closes #54877

X-original-commit: 8629fa3
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
robodoo pushed a commit that referenced this issue Aug 4, 2020
@Yemeni @mart-e
[FIX] web: avoid double switching in RTL
2b617d5 
The direction arrows in the datepicker were switched a first time in
fontawesome_overridden.scss

  .o_rtl
    ..fa-chevron-left,.fa-chevron-right
       transform: rotate(-180deg);

and a second time in datepicker.scss
  .o_rtl
     .bootstrap-datetimepicker-widget
        .prev,.next
	   transform: rotate(180deg);

The buttons were flipped twice

Signed the Odoo CLA

Fixes #50090
Closes #53369

closes #54879

X-original-commit: 8629fa3
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
13.0 Internationalization about translations
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Yemeni @Yenthe666 @RachidAlassir