Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if "Receive Inbox Notifications by Email" is set to never then sending things by email doesn't work #7374

Closed
AlanBell opened this issue Jun 30, 2015 · 15 comments

Comments

@AlanBell
Copy link

Default settings

  • Set a partner to Receive Inbox Notifications by Email=Always
  • Create a sales order and confirm it, the partner should get a "Quotation confirmed" email and be added as a follower of the order
  • Send the order by email and the partner should get the full email with the PDF.

Attempting to prevent the first email:

  • Now set the partner to Receive Inbox Notifications by Email=Never
  • Create a sales order and confirm it, the partner will not get a notification email but will be added as a follower of the order
  • Send the order by email and the partner will not get the full email with the PDF.

The partner should not get emails just for being a follower of the document however if you explicitly send them an email they should get it.

@richard-willdooit
Copy link
Contributor

+1 - We would still like to be able to explicitly send messages to a recipient, but do not want to send them general messages that come from the messaging system.

@samuellefever
Copy link

+1

@spadae22
Copy link
Contributor

Yes I agree, customers are reporting emails they do not want. You should be able to define what they receive. We send emails for orders every night so setting "No Messages" is not an option.

@dbertha
Copy link

dbertha commented Jul 29, 2015

+1, very annoying.
I need the portal module but want to disable the "quotation send" mail notification. I'll have to write a new module to undo the effects of portal module.

@joolsr
Copy link

joolsr commented Aug 4, 2015

Looking at recent runbot for how these things are handled in master (ie v9 to come), they are showing much more fine grained control of what followers can control, including about another 5 different facets that can be controlled.
v9image

This may or may not help with your slightly different requirement, but the fact that you can choose to just allow followers to see email updates only for example, indicates that it may be best to allow inbox notifications but control more specifically what is shown on updates to followers ..

@aftabnaveed
Copy link

Never means never, I think it should not let you send emails. Funny thing is there is no Control on Sale Confirmation Email that is which should be fixed and that email should not be sent automatically. That looks like a bug to me.

@AlanBell
Copy link
Author

well if it was a "do not mail" field then yes, blocking all mails would be justified - but I would want a big fat error message when I try to send them a mail rather than a silent failure, but the control I want is "don't send this person notifications", which is what the field claims to do. Customers get set as a follower of their quotes by default, so every step of the way they get update notifications - which might well not be wanted.

@proscion
Copy link

@AlanBell you are so right...this feature is so annoying ! users keep complaining

@drummingbird
Copy link

+1 This is a super annoying bug for website sales!

@blaggacao
Copy link
Contributor

blaggacao commented Apr 16, 2016

@odony Who might be in charge of this one?
based on scanning commit history, probably: @simongoffin @tde-banana-odoo

@blaggacao
Copy link
Contributor

blaggacao commented Apr 16, 2016

However, allegedly, there is an option to take fine grained control of different subtypes. see image...
capture

Notwithstanding, Alan is quite right in his pledge for:
a) semantical correction
b) differentiation "notification" from "intentional (manually triggered) emails" and that this should be configurable on partners as a further drop down option on the cited field.

@blaggacao
Copy link
Contributor

This seems related, at least for my use case: 1b5c2ce (see config option in image of my last post)

@blaggacao
Copy link
Contributor

Here is where internal flag takes effect:

if self_sudo.subtype_id and self.model and self.res_id:
followers = self.env['mail.followers'].sudo().search([
('res_model', '=', self.model),
('res_id', '=', self.res_id)
]).filtered(lambda fol: self.subtype_id in fol.subtype_ids)
if self_sudo.subtype_id.internal:
followers = followers.filtered(lambda fol: fol.channel_id or (fol.partner_id.user_ids and group_user in fol.partner_id.user_ids[0].mapped('groups_id')))
channels = self_sudo.channel_ids | followers.mapped('channel_id')
partners = self_sudo.partner_ids | followers.mapped('partner_id')
else:
channels = self_sudo.channel_ids
partners = self_sudo.partner_ids

Another beast is the following, which marks an email as notification automatically in many cases.

def create(self, values):
# notification field: if not set, set if mail comes from an existing mail.message
if 'notification' not in values and values.get('mail_message_id'):
values['notification'] = True
return super(MailMail, self).create(values)

I'm not yet sure though if the latter (which is triggered in the described case) is responsible for the odd behaviour described by the OP.

@adamrumjahn
Copy link

+10!

I just wasted a good part of my week before arriving at this page. This is really annoying. Send Email should mean exactly that. If a user has selected "Never" for Email Notifications, that is fine for "Notifications", but I wanted to send them an EMAIL, not a notification.

Emails and Notifications are NOT the same. If we want to give users the ability to filter them BOTH, then that's fine, create another check box in the user preferences and allow a default value. But Emails and Notifications should definitely not be categorized as the same.

Either that, OR the Send Email button should be renamed to "Send Message" and any references to email should be hidden.

@pedrobaeza
Copy link
Collaborator

Well, although it seems strange, that's the intended behavior and it's logical in its way: not receiving by email things is to not send anything. As there is the possibility of having a portal, that recipient can see also things in Odoo messaging, so it's coherent.

I close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests