-
Notifications
You must be signed in to change notification settings - Fork 23.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] base: use time zone aware display field for currency rates #100123
Closed
khah-odoo
wants to merge
1
commit into
odoo:13.0
from
odoo-dev:13.0-fix-currency-rate-display-field-khah
Closed
[FIX] base: use time zone aware display field for currency rates #100123
khah-odoo
wants to merge
1
commit into
odoo:13.0
from
odoo-dev:13.0-fix-currency-rate-display-field-khah
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steps to reproduce: 1. change system and admin's time zone to one with a different date than UTC 2. enable multi-currency in the accounting module 3. add rates for the current date in local time zone and UTC 4. go to settings > currencies 5. the rate for the UTC date is displayed To fix this, we should use a time zone aware field in `res_currency`. opw-2945108
william-andre
approved these changes
Sep 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robodoo r+
@khah-odoo @william-andre staging failed: ci/runbot (view more at https://runbot.odoo.com/runbot/build/19752689) |
@robodoo retry |
robodoo
pushed a commit
that referenced
this pull request
Sep 29, 2022
Steps to reproduce: 1. change system and admin's time zone to one with a different date than UTC 2. enable multi-currency in the accounting module 3. add rates for the current date in local time zone and UTC 4. go to settings > currencies 5. the rate for the UTC date is displayed To fix this, we should use a time zone aware field in `res_currency`. opw-2945108 closes #100123 Signed-off-by: William André (wan) <wan@odoo.com>
This was referenced Sep 29, 2022
gamarino
pushed a commit
to numaes/numa-public-odoo
that referenced
this pull request
Jan 11, 2023
Steps to reproduce: 1. change system and admin's time zone to one with a different date than UTC 2. enable multi-currency in the accounting module 3. add rates for the current date in local time zone and UTC 4. go to settings > currencies 5. the rate for the UTC date is displayed To fix this, we should use a time zone aware field in `res_currency`. opw-2945108 closes odoo/odoo#100123 Signed-off-by: William André (wan) <wan@odoo.com>
zamberjo
pushed a commit
to aurestic/OpenUpgrade
that referenced
this pull request
Mar 1, 2023
Steps to reproduce: 1. change system and admin's time zone to one with a different date than UTC 2. enable multi-currency in the accounting module 3. add rates for the current date in local time zone and UTC 4. go to settings > currencies 5. the rate for the UTC date is displayed To fix this, we should use a time zone aware field in `res_currency`. opw-2945108 closes odoo/odoo#100123 Signed-off-by: William André (wan) <wan@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
To fix this, we should use a time zone aware field in
res_currency
.opw-2945108
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr