Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] base: use time zone aware display field for currency rates #100123

Conversation

khah-odoo
Copy link
Contributor

Steps to reproduce:

  1. change system and admin's time zone to one with a different date than UTC
  2. enable multi-currency in the accounting module
  3. add rates for the current date in local time zone and UTC
  4. go to settings > currencies
  5. the rate for the UTC date is displayed

To fix this, we should use a time zone aware field in res_currency.

opw-2945108

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Steps to reproduce:

1. change system and admin's time zone to one with a different
date than UTC
2. enable multi-currency in the accounting module
3. add rates for the current date in local time zone and UTC
4. go to settings > currencies
5. the rate for the UTC date is displayed

To fix this, we should use a time zone aware field in `res_currency`.

opw-2945108
@robodoo
Copy link
Contributor

robodoo commented Sep 14, 2022

Pull request status dashboard

@C3POdoo C3POdoo requested review from a team September 14, 2022 08:14
@C3POdoo C3POdoo added the OE the report is linked to a support ticket (opw-...) label Sep 14, 2022
Copy link
Contributor

@william-andre william-andre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robodoo
Copy link
Contributor

robodoo commented Sep 29, 2022

@khah-odoo @william-andre staging failed: ci/runbot (view more at https://runbot.odoo.com/runbot/build/19752689)

@william-andre
Copy link
Contributor

@robodoo retry

robodoo pushed a commit that referenced this pull request Sep 29, 2022
Steps to reproduce:

1. change system and admin's time zone to one with a different
date than UTC
2. enable multi-currency in the accounting module
3. add rates for the current date in local time zone and UTC
4. go to settings > currencies
5. the rate for the UTC date is displayed

To fix this, we should use a time zone aware field in `res_currency`.

opw-2945108

closes #100123

Signed-off-by: William André (wan) <wan@odoo.com>
@robodoo robodoo temporarily deployed to merge September 29, 2022 14:52 Inactive
@robodoo robodoo closed this Sep 29, 2022
@fw-bot fw-bot deleted the 13.0-fix-currency-rate-display-field-khah branch October 13, 2022 15:46
gamarino pushed a commit to numaes/numa-public-odoo that referenced this pull request Jan 11, 2023
Steps to reproduce:

1. change system and admin's time zone to one with a different
date than UTC
2. enable multi-currency in the accounting module
3. add rates for the current date in local time zone and UTC
4. go to settings > currencies
5. the rate for the UTC date is displayed

To fix this, we should use a time zone aware field in `res_currency`.

opw-2945108

closes odoo/odoo#100123

Signed-off-by: William André (wan) <wan@odoo.com>
zamberjo pushed a commit to aurestic/OpenUpgrade that referenced this pull request Mar 1, 2023
Steps to reproduce:

1. change system and admin's time zone to one with a different
date than UTC
2. enable multi-currency in the accounting module
3. add rates for the current date in local time zone and UTC
4. go to settings > currencies
5. the rate for the UTC date is displayed

To fix this, we should use a time zone aware field in `res_currency`.

opw-2945108

closes odoo/odoo#100123

Signed-off-by: William André (wan) <wan@odoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OE the report is linked to a support ticket (opw-...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants