Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] l10n_fr: fix the CoA, Taxes, Fiscal Pos, Group of tax #102598

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Oct 7, 2022

This commit cleans the tax groups:

  • it removes the negative tax groups
  • it makes sure that there is only one tax group per tax rate
  • all the taxes with the same rates are attached to a single tax group

This commit splits the taxes to make the distinction between the goods and services.
In addition, the fiscal positions are also updated accordingly (make sure to map to another
one having the same scope: goods/services and type: sale/purchase).

These changes are based on the reliable feedback of LPDE (Didier Six).

In addition, the tax report is updated to the 2022 version and the new tax report lines
are linked to the taxes.

task-2674047

Forward-Port-Of: #102556
Forward-Port-Of: #84918

@robodoo
Copy link
Contributor

robodoo commented Oct 7, 2022

@fw-bot
Copy link
Contributor Author

fw-bot commented Oct 7, 2022

@JulienVR @oco-odoo cherrypicking of pull request #84918 failed.

stderr:

13:08:21.748317 git.c:344               trace: built-in: git cherry-pick 2b76331811785bb14da2557e689ed96336ea0e4f
error: could not apply 2b7633181178... [FIX] l10n_fr: clean Tax Groups, CoA, Taxes, Fiscal Positions, Tax report
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'
----------
status:

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

@robodoo robodoo added conflict There was an error while creating this forward-port PR forwardport This PR was created by @fw-bot labels Oct 7, 2022
@C3POdoo C3POdoo added the RD research & development, internal work label Oct 7, 2022
@JulienVR JulienVR force-pushed the 16.0-14.0-l10n_fr-coa-tax-improvements-juvr-fnCx-fw branch from 6967cac to 152cc90 Compare October 7, 2022 12:30
@C3POdoo C3POdoo requested review from a team and h4818 and removed request for a team October 7, 2022 12:32
…port

This commit cleans the tax groups:
- it removes the negative tax groups
- it makes sure that there is only one tax group per tax rate
- all the taxes with the same rates are attached to a single tax group

This commit splits the taxes to make the distinction between the goods and services.
In addition, the fiscal positions are also updated accordingly (make sure to map to another
one having the same scope: goods/services and type: sale/purchase).

These changes are based on the reliable feedback of LPDE (Didier Six). No tax were removed
from the old version. Only some were split, the others were kept (but modified).

In addition, the tax report is updated to the 2022 version and the new tax report lines
are linked to the taxes.

task-2674047

X-original-commit: odoo@9799d65
@JulienVR JulienVR force-pushed the 16.0-14.0-l10n_fr-coa-tax-improvements-juvr-fnCx-fw branch from 152cc90 to 24c6525 Compare October 7, 2022 13:33
@JulienVR
Copy link
Contributor

JulienVR commented Oct 7, 2022

@robodoo r+

robodoo pushed a commit that referenced this pull request Oct 7, 2022
…port

This commit cleans the tax groups:
- it removes the negative tax groups
- it makes sure that there is only one tax group per tax rate
- all the taxes with the same rates are attached to a single tax group

This commit splits the taxes to make the distinction between the goods and services.
In addition, the fiscal positions are also updated accordingly (make sure to map to another
one having the same scope: goods/services and type: sale/purchase).

These changes are based on the reliable feedback of LPDE (Didier Six). No tax were removed
from the old version. Only some were split, the others were kept (but modified).

In addition, the tax report is updated to the 2022 version and the new tax report lines
are linked to the taxes.

task-2674047

closes #102598

X-original-commit: 9799d65
Signed-off-by: Olivier Colson (oco) <oco@odoo.com>
Signed-off-by: Julien Van Roy <juvr@odoo.com>
@robodoo robodoo temporarily deployed to merge October 7, 2022 23:15 Inactive
@robodoo robodoo closed this Oct 7, 2022
@fw-bot fw-bot deleted the 16.0-14.0-l10n_fr-coa-tax-improvements-juvr-fnCx-fw branch October 21, 2022 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflict There was an error while creating this forward-port PR forwardport This PR was created by @fw-bot RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants