[IMP] base,*: remove __last_update from all models #105739
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentSchippefilt
force-pushed
the
master-remove_last_update-vsc
branch
3 times, most recently
from
51c2505
to
0304d64
Compare
tde-banana-odoo
approved these changes
Nov 17, 2022
|
@robodoo override=ci/security
|
rco-odoo
reviewed
Nov 17, 2022
VincentSchippefilt
force-pushed
the
master-remove_last_update-vsc
branch
4 times, most recently
from
f99f8a9
to
d00ee49
Compare
rco-odoo
reviewed
Nov 24, 2022
VincentSchippefilt
force-pushed
the
master-remove_last_update-vsc
branch
from
d00ee49
to
e0e61c2
Compare
VincentSchippefilt
force-pushed
the
master-remove_last_update-vsc
branch
6 times, most recently
from
9d168c9
to
159f0ea
Compare
VincentSchippefilt
force-pushed
the
master-remove_last_update-vsc
branch
from
159f0ea
to
7094c2f
Compare
|
robodoo r+ |
|
@VincentSchippefilt linked pull request(s) odoo/upgrade#4038 not ready. Linked PRs are not staged until all of them are ready. |
The main goal of this commit is to reduce the size of the registry by removing the (almost) useless __last_update field. Statistics # of fields with all modules installed: before 30184 fields, 1299x last_update (4.30%) Before this commit, the computed field __last_update was added on every model. The idea behind this field was to have a computed field that had either the write_date or the create_date if the write_date was empty. However, the write_date is always written, even on creation, making it useless to have the computed field __last_update After this update, we completely remove from BaseModel: * __last_update * CONCURRENCY_CHECK_FIELD that was always defined as "__last_update" * _compute_concurrency_field that was the compute function for __last_update task-id: 3062140 (part of 3062137 improve registry load time)
rco-odoo
force-pushed
the
master-remove_last_update-vsc
branch
from
7094c2f
to
c2f5268
Compare
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Dec 7, 2022
The main goal of this commit is to reduce the size of the registry by removing the (almost) useless __last_update field. Statistics # of fields with all modules installed: before 30184 fields, 1299x last_update (4.30%) Before this commit, the computed field __last_update was added on every model. The idea behind this field was to have a computed field that had either the write_date or the create_date if the write_date was empty. However, the write_date is always written, even on creation, making it useless to have the computed field __last_update After this update, we completely remove from BaseModel: * __last_update * CONCURRENCY_CHECK_FIELD that was always defined as "__last_update" * _compute_concurrency_field that was the compute function for __last_update closes #105739 Task-id: 3062140 (part of 3062137 improve registry load time) Related: odoo/upgrade#4038 Related: odoo/enterprise#33939 Signed-off-by: Raphael Collet <rco@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal of this commit is to reduce the size of the registry by
removing the (almost) useless __last_update field.
Statistics # of fields with all modules installed:
before 30184 fields, 1299x last_update (4.30%)
Before this commit, the computed field __last_update was added on every model.
The idea behind this field was to have a computed field that had either
the write_date or the create_date if the write_date was empty. However,
the write_date is always written, even on creation, making it useless
to have the computed field __last_update
After this update, we completely remove from BaseModel:
task-id: 3062140 (part of 3062137 improve registry load time)
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr