Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fix subcontractiong MTO rule type #106405

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lk-eska
Copy link
Contributor

@lk-eska lk-eska commented Nov 24, 2022

Description of the issue/feature this PR addresses:
This leads to mto to trigger (purchase) even if the product exists in the stock. Problem also exists in 14.0 15.0...

Current behavior before PR:
trigger (purchase) even if the product exists in the stock.

Desired behavior after PR is merged:
use the stock if the product exists in the stock.

Copy of the PR without the commit e-mail #92476


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo
Copy link
Contributor

robodoo commented Nov 24, 2022

@C3POdoo C3POdoo requested a review from a team November 24, 2022 11:19
@lk-eska lk-eska changed the title Fix subcontractiong MTO rule type [FIX] Fix subcontractiong MTO rule type Nov 24, 2022
@C3POdoo C3POdoo added the Logistics about stock, mrp, delivery, purchase label Nov 24, 2022
@Whenrow
Copy link
Contributor

Whenrow commented Nov 25, 2022

Hello. This fix is good. Could you rewrite your commit message following our guidelines ? (see https://www.odoo.com/documentation/16.0/contributing/development/coding_guidelines.html#commit-message-structure)
Thank you

@lk-eska lk-eska force-pushed the master-subcontracting-mto-rule branch from 5fdc8a6 to 9faf73f Compare November 28, 2022 10:52
@lk-eska
Copy link
Contributor Author

lk-eska commented Nov 28, 2022

Hello. This fix is good. Could you rewrite your commit message following our guidelines ? (see https://www.odoo.com/documentation/16.0/contributing/development/coding_guidelines.html#commit-message-structure) Thank you

[FIX] is added

@Whenrow
Copy link
Contributor

Whenrow commented Dec 5, 2022

Sorry to bother you again, but we specify the module name in the commit title. So in this case

[FIX] mrp_subcontracting: fix MTO rule

@lk-eska lk-eska force-pushed the master-subcontracting-mto-rule branch from 9faf73f to 23b14f8 Compare December 6, 2022 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Logistics about stock, mrp, delivery, purchase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants