[FIX] account,l10n_{au,in,gcc_invoice}: distinguish credit note titles #106692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epictete
reviewed
Nov 29, 2022
Comment on lines
77
to
82
| <span t-if="o.move_type == 'out_refund' and o.state == 'draft'"> | ||
| إشعار خصم المسودة | ||
| </span> | ||
| <span t-if="o.move_type == 'out_refund' and o.state == 'cancel'"> | ||
| إشعار خصم ملغاة | ||
| </span> |
There was a problem hiding this comment.
Suggested change
| <span t-if="o.move_type == 'out_refund' and o.state == 'draft'"> | |
| إشعار خصم المسودة | |
| </span> | |
| <span t-if="o.move_type == 'out_refund' and o.state == 'cancel'"> | |
| إشعار خصم ملغاة | |
| </span> | |
| <span t-elif="o.move_type == 'out_refund' and o.state == 'draft'"> | |
| إشعار خصم المسودة | |
| </span> | |
| <span t-elif="o.move_type == 'out_refund' and o.state == 'cancel'"> | |
| إشعار خصم ملغاة | |
| </span> |
There was a problem hiding this comment.
@epictete Absolutely. Thought I'd done it, but Monday brain ... 😄 There you go!
Currently we distinguish customer invoice titles based on the state they are in: draft, posted or cancelled. For the customer credit notes we did not have this dinstinction. This fix makes sure that the title of a credit note is also adapted based on its state. [task-3067251](https://www.odoo.com/web#id=3067251&cids=1&menu_id=4720&action=4043&model=project.task&view_type=form)
dylankiss
force-pushed
the
master-credit_note_titles-dyki
branch
from
dc2624e
to
a58b979
Compare
|
@robodoo r+ |
|
@dylankiss @epictete linked pull request(s) odoo/enterprise#34464 not ready. Linked PRs are not staged until all of them are ready. |
robodoo
pushed a commit
that referenced
this pull request
Nov 29, 2022
Currently we distinguish customer invoice titles based on the state they are in: draft, posted or cancelled. For the customer credit notes we did not have this dinstinction. This fix makes sure that the title of a credit note is also adapted based on its state. [task-3067251](https://www.odoo.com/web#id=3067251&cids=1&menu_id=4720&action=4043&model=project.task&view_type=form) closes #106692 Related: odoo/enterprise#34464 Signed-off-by: John Laterre (jol) <jol@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we distinguish customer invoice titles based on the state they are in: draft, posted or cancelled. For the customer credit notes we did not have this dinstinction.
This fix makes sure that the title of a credit note is also adapted based on its state.
task-3067251
Retarget of #106262
Related: https://github.com/odoo/enterprise/pull/34464
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr