Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] base: profiling qweb field visibility #107051

Closed
wants to merge 1 commit into from

Conversation

niyasraphy
Copy link
Contributor

Description of the issue/feature this PR addresses: in ir.profile model currently the qweb field is not getting invisible when the value is empty.

Settings -> Technical -> Database Structure -> Profiling

Current behavior before PR: field is not getting invisible when there is no value

Desired behavior after PR is merged: field will be invisible when there is no value


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo
Copy link
Contributor

robodoo commented Dec 1, 2022

@C3POdoo C3POdoo requested a review from a team December 1, 2022 18:11
@niyasraphy niyasraphy changed the title [IMP] base: profiling qweb field visibility [FIX] base: profiling qweb field visibility Dec 1, 2022
@niyasraphy
Copy link
Contributor Author

hi @Julien00859 ,
if you have time, can you review this.
thanks

@Julien00859
Copy link
Member

Hello @niyasraphy funny enough I was already reviewing this PR at the moment you sent the message :) I'm going through all my missed notifications so do not worry, if rd-framework-py is notified, I'll review the PR at some point ;)

Copy link
Member

@Julien00859 Julien00859 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo pushed a commit that referenced this pull request Dec 12, 2022
closes #107051

Signed-off-by: Julien Castiaux <juc@odoo.com>
@robodoo robodoo temporarily deployed to merge December 12, 2022 14:23 Inactive
@robodoo robodoo closed this Dec 12, 2022
@fw-bot
Copy link
Contributor

fw-bot commented Dec 16, 2022

@niyasraphy @Julien00859 this pull request has forward-port PRs awaiting action (not merged or closed):
#107763

@fw-bot
Copy link
Contributor

fw-bot commented Dec 17, 2022

@niyasraphy @Julien00859 this pull request has forward-port PRs awaiting action (not merged or closed):
#108192

2 similar comments
@fw-bot
Copy link
Contributor

fw-bot commented Dec 18, 2022

@niyasraphy @Julien00859 this pull request has forward-port PRs awaiting action (not merged or closed):
#108192

@fw-bot
Copy link
Contributor

fw-bot commented Dec 19, 2022

@niyasraphy @Julien00859 this pull request has forward-port PRs awaiting action (not merged or closed):
#108192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants