[IMP] Form: Add _warning attribute to check its value in tests

[rousseldenis]

---

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

[robodoo]

Pull request status dashboard.

[rousseldenis]

@rco-odoo

[Julien00859]

wouldn't assertLogs work?

[Xavier-Do]

You could also patch the onchange method to intercept the result if needed.

[rousseldenis]

You could also patch the onchange method to intercept the result if needed.

Integrated helper should be great (as don't need to patch each time).

But I didn't know the assertLogs().

The working command looks like this:

IMHO, the logger attribute is quite tricky for normal developers. Don't you think ?

[xmo-odoo]

You don't need to use getChild when the entire logger name is hardcoded. Furthermore assertLogs can take a logger or a logger name.

So the actual code is

with self.assertLogs("odoo.tests.common.onchange", level=logging.WARNING):
    ...

which is

1. standard code you can find in the official Python documentation
2. applicable to any situation where you want to check logging

IMHO, the logger attribute is quite tricky for normal developers. Don't you think ?

More tricky than a magical attribute which may or may not be present and can't be retrieved normally?

[rousseldenis]

You don't need to use getChild when the entire logger name is hardcoded. Furthermore assertLogs can take a logger or a logger name.

So the actual code is

with self.assertLogs("odoo.tests.common.onchange", level=logging.WARNING):
    ...

which is

1. standard code you can find in the official Python documentation
2. applicable to any situation where you want to check logging

IMHO, the logger attribute is quite tricky for normal developers. Don't you think ?

Great!

It was a proposal to enhance dev experience in test writing.

Especially in this case.

More tricky than a magical attribute which may or may not be present and can't be retrieved normally?

We could maybe initialize the attribute as void to make it persistent and have an helper method to retrieve it.

My two cents.