[FW][FIX] website: prevent crash for non admin publisher when click on form #109112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When editing a website form, a `search_read` request is fired on `ir.model` model to get the list of possible form actions (create ticket, create opportunity, etc.). But since commit [1] in Odoo 15, non-admin users don't have read access anymore on this model, leading to a traceback when clicking on a form in edit mode. Steps to reproduce (as designer): - Install only website and login as admin - Make "portal" user an internal user and give him "Editor and Designer" rights - Login as "portal" user - Enter edit mode on any page and drag & drop the form snippet, or simply go to /contactus page which already has one - Click on the form -> Traceback Steps to reproduce (as publisher/restricted editor): - Install website_hr_recruitment - Make "portal" user an internal user and give him the following rights: - Website: Restricted Editor - Recruitment: Administrator - Login as "portal" user - Go to a job page like /jobs/detail/experienced-developer-4 - Enter edit mode and drag & drop the form snippet - It will crash [1]: odoo@5dc4cff opw-3098097 opw-3101884 X-original-commit: 0b439de
|
This PR targets saas-15.3 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@fw-bot r+ next version is to be fixed due to group name change |
robodoo
pushed a commit
that referenced
this pull request
Jan 5, 2023
When editing a website form, a `search_read` request is fired on `ir.model` model to get the list of possible form actions (create ticket, create opportunity, etc.). But since commit [1] in Odoo 15, non-admin users don't have read access anymore on this model, leading to a traceback when clicking on a form in edit mode. Steps to reproduce (as designer): - Install only website and login as admin - Make "portal" user an internal user and give him "Editor and Designer" rights - Login as "portal" user - Enter edit mode on any page and drag & drop the form snippet, or simply go to /contactus page which already has one - Click on the form -> Traceback Steps to reproduce (as publisher/restricted editor): - Install website_hr_recruitment - Make "portal" user an internal user and give him the following rights: - Website: Restricted Editor - Recruitment: Administrator - Login as "portal" user - Go to a job page like /jobs/detail/experienced-developer-4 - Enter edit mode and drag & drop the form snippet - It will crash [1]: 5dc4cff opw-3098097 opw-3101884 closes #109112 X-original-commit: 0b439de Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com> Signed-off-by: Romain Derie (rde) <rde@odoo.com>
fw-bot
deleted the
saas-15.3-15.0-opw-3098097-website-forms-access--bugfix-IEL-_55Z-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When editing a website form, a
search_readrequest is fired onir.modelmodel to get the list of possible form actions (createticket, create opportunity, etc.).
But since commit 1 in Odoo 15, non-admin users don't have read access
anymore on this model, leading to a traceback when clicking on a form in
edit mode.
Steps to reproduce (as designer):
rights
simply go to /contactus page which already has one
Steps to reproduce (as publisher/restricted editor):
opw-3098097
opw-3101884
Forward-Port-Of: #108680