[FW][FIX] portal: fix portal title for the salesperson data #109134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, if the helpdesk module was installed, the title of the salesperson data was changed from "Your contact" to "Salesperson" for portal users. This did not add any value and the title of the tab also became "Salesperson" which we do not want. This commit allows to keep the title "Your contact" above the salesperson information and to not change the tab title. Steps to reproduce the problem fixed by this commit: - Run Odoo enterprise with helpdesk and sales installed. - As the admin, create a helpdesk ticket with Joel Willis (portal user) as the customer and save. - Click on Joel Willis, select the "Sales & Purchases" tab and set a salesperson. => Log in as Joel Willis and on /my, you will have "Salesperson" as the title of the tab. This bad behavior is due to [this commit] that added a title above the salesperson information. But with this change the title of the tab was also impacted. Then [this other commit] added a default title above the salesperson information. We can be satisfied with this default title which does not alter the title of the tab. [this commit]: odoo/enterprise@700e9de [this other commit]: odoo@d5c66ca opw-3103718 X-original-commit: 1ebeec9
|
This PR targets saas-15.3 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo
pushed a commit
that referenced
this pull request
Jan 5, 2023
Before this commit, if the helpdesk module was installed, the title of the salesperson data was changed from "Your contact" to "Salesperson" for portal users. This did not add any value and the title of the tab also became "Salesperson" which we do not want. This commit allows to keep the title "Your contact" above the salesperson information and to not change the tab title. Steps to reproduce the problem fixed by this commit: - Run Odoo enterprise with helpdesk and sales installed. - As the admin, create a helpdesk ticket with Joel Willis (portal user) as the customer and save. - Click on Joel Willis, select the "Sales & Purchases" tab and set a salesperson. => Log in as Joel Willis and on /my, you will have "Salesperson" as the title of the tab. This bad behavior is due to [this commit] that added a title above the salesperson information. But with this change the title of the tab was also impacted. Then [this other commit] added a default title above the salesperson information. We can be satisfied with this default title which does not alter the title of the tab. [this commit]: odoo/enterprise@700e9de [this other commit]: d5c66ca opw-3103718 closes #109134 X-original-commit: 1ebeec9 Related: odoo/enterprise#35442 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, if the helpdesk module was installed, the title of the salesperson data was changed from "Your contact" to "Salesperson" for portal users. This did not add any value and the title of the tab also became "Salesperson" which we do not want. This commit allows to keep the title "Your contact" above the salesperson information and to not change the tab title.
Steps to reproduce the problem fixed by this commit:
=> Log in as Joel Willis and on /my, you will have "Salesperson" as the title of the tab. This bad behavior is due to [this commit] that added a title above the salesperson information. But with this change the title of the tab was also impacted. Then [this other commit] added a default title above the salesperson information. We can be satisfied with this default title which does not alter the title of the tab.
[this commit]: https://github.com/odoo/enterprise/commit/700e9dec4a5c9fca354e063d6a85b0514832c84c [this other commit]: d5c66ca
opw-3103718
Before:
After:
Forward-Port-Of: #108705