[FW][FIX] base: missing MIME-Version header #109184
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Send an rich HTML email from Odoo, it lands in spam whereas it would land in inbox in 13.0. The problem is due to a missing "MIME-Version: 1.0" header on the email. This header is correctly set on both the html and text alternatives of the messages but it should be set on the enveloppe too. The problem is present in the newer EmailMessage mail API of python that is used since 14.0. Using the newer API, it doesn't set the header on the enveloppe itself. This reverts commit 8663f1e. opw-3098621 X-original-commit: c480d2b
|
This PR targets saas-15.3 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo
pushed a commit
that referenced
this pull request
Jan 5, 2023
Send an rich HTML email from Odoo, it lands in spam whereas it would land in inbox in 13.0. The problem is due to a missing "MIME-Version: 1.0" header on the email. This header is correctly set on both the html and text alternatives of the messages but it should be set on the enveloppe too. The problem is present in the newer EmailMessage mail API of python that is used since 14.0. Using the newer API, it doesn't set the header on the enveloppe itself. This reverts commit 8663f1e. opw-3098621 closes #109184 X-original-commit: c480d2b Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com> Signed-off-by: Julien Castiaux <juc@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a second attempt at #64651
The reverted commit fixes the lack of a
MIME-Versionheader on themail enveloppe by using
set_charset. More specifically,set_charsetsets three headers:
MIME-VersionContent-TypeTransert-Encodingof them only
MIME-Versionwas required.The function was called prior of setting the mail's content or
alternatives.
Upon adding an alternative, python converts the current mail to a
multipart equivalent. Because of the two extra CT and TE headers, it
considered there was some content that needed to be moved inside of a
part, i.e. it created an empty part with the two CT and TE headers
set.
This empty part made our emails incompatible with Google G-Suite in case
an rich html footer was included via the G-Suite interface. Google would
wrongly reorder the email and move any text/plain part to the end of the
email and would show that part to the user instead of any text/html
part.
Google shouldn't change the order of our alternatives but he does and
it is easier for me to change our code than to fix google's.
Forward-Port-Of: #109056
Forward-Port-Of: #108499