Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] mrp: byproducts follow putaway rules #109198

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Jan 5, 2023

Before this commit, the byproduct and putaway feature do not work together. More specifically, changing the quantity to produce on a manufacturing order will
create automatically a byproduct move line (or update the existing one with the new quantity) but never look for a putaway rule to apply.

This commit makes use of _set_quantity_done() method on stock.move that do call the putaway strategy mechanism

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #109113
Forward-Port-Of: #109077

Before this commit, the byproduct and putaway feature do not work
together. More specifically, changing the quantity to produce on a
manufacturing order will create automatically a byproduct move line (or
update the existing one with the new quantity) but never look for a
putaway rule to apply.

This commit makes use of `_set_quantity_done()` method on `stock.move`
that *do* call the putaway strategy mechanism

X-original-commit: 18e55b0
@robodoo
Copy link
Contributor

robodoo commented Jan 5, 2023

@fw-bot
Copy link
Contributor Author

fw-bot commented Jan 5, 2023

This PR targets saas-15.3 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@C3POdoo C3POdoo added the RD research & development, internal work label Jan 5, 2023
@robodoo robodoo added the forwardport This PR was created by @fw-bot label Jan 5, 2023
@fw-bot
Copy link
Contributor Author

fw-bot commented Jan 5, 2023

@Whenrow @svs-odoo the next pull request (#109215) is in conflict. You can merge the chain up to here by saying

@fw-bot r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@Whenrow
Copy link
Contributor

Whenrow commented Jan 6, 2023

@fw-bot r+

robodoo pushed a commit that referenced this pull request Jan 6, 2023
Before this commit, the byproduct and putaway feature do not work
together. More specifically, changing the quantity to produce on a
manufacturing order will create automatically a byproduct move line (or
update the existing one with the new quantity) but never look for a
putaway rule to apply.

This commit makes use of `_set_quantity_done()` method on `stock.move`
that *do* call the putaway strategy mechanism

closes #109198

X-original-commit: 18e55b0
Signed-off-by: Steve Van Essche <svs@odoo.com>
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
@robodoo robodoo temporarily deployed to merge January 6, 2023 12:24 Inactive
@robodoo robodoo closed this Jan 6, 2023
@fw-bot fw-bot deleted the saas-15.3-15.0-byproduct-putaway-whe-puov-fw branch January 20, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forwardport This PR was created by @fw-bot RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants