-
Notifications
You must be signed in to change notification settings - Fork 23.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FW][FIX] base: inherit the industry field from parent #109248
Closed
fw-bot
wants to merge
1
commit into
odoo:saas-15.3
from
odoo-dev:saas-15.3-14.0-opw-3085032-grouping_sector_of_activity-thle-kvdX-fw
Closed
[FW][FIX] base: inherit the industry field from parent #109248
fw-bot
wants to merge
1
commit into
odoo:saas-15.3
from
odoo-dev:saas-15.3-14.0-opw-3085032-grouping_sector_of_activity-thle-kvdX-fw
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@thle-odoo @tivisse cherrypicking of pull request #107918 failed. stdout:
stderr:
Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. |
robodoo
added
conflict
There was an error while creating this forward-port PR
forwardport
This PR was created by @fw-bot
labels
Jan 5, 2023
Steps to reproduce: - install "contacts" and "sale_management" module; - create a company contact with a value for "Industry" (Sales & Purchase tab); - create an employee who works in this company; - create two orders (one with the company and one with the employee); - go to sales reporting tab and select the pivot view; - filter by "Customer Industry" and then by "Customer"; Issue: The employee is not placed in the right category of industry. He should be in the same category as the company he works in. Cause: When creating a contact, the `industry_id` field is not passed from parent to children. (Moreover, this field being invisible for an "individual" contact, it is not possible to give it a value without using the studio application.) Solution: Add `industry_id` to `_commercial_fields`. opw-3085032 X-original-commit: 8aa4732
thle-odoo
force-pushed
the
saas-15.3-14.0-opw-3085032-grouping_sector_of_activity-thle-kvdX-fw
branch
from
January 6, 2023 07:47
2500f7b
to
b6799a4
Compare
@robodoo r+ |
C3POdoo
requested review from
a team,
rco-odoo and
Julien00859
and removed request for
a team
January 6, 2023 07:48
robodoo
pushed a commit
that referenced
this pull request
Jan 6, 2023
Steps to reproduce: - install "contacts" and "sale_management" module; - create a company contact with a value for "Industry" (Sales & Purchase tab); - create an employee who works in this company; - create two orders (one with the company and one with the employee); - go to sales reporting tab and select the pivot view; - filter by "Customer Industry" and then by "Customer"; Issue: The employee is not placed in the right category of industry. He should be in the same category as the company he works in. Cause: When creating a contact, the `industry_id` field is not passed from parent to children. (Moreover, this field being invisible for an "individual" contact, it is not possible to give it a value without using the studio application.) Solution: Add `industry_id` to `_commercial_fields`. opw-3085032 closes #109248 X-original-commit: 8aa4732 Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com> Signed-off-by: Lefebvre Thomas (thle) <thle@odoo.com>
fw-bot
deleted the
saas-15.3-14.0-opw-3085032-grouping_sector_of_activity-thle-kvdX-fw
branch
January 20, 2023 09:47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
conflict
There was an error while creating this forward-port PR
forwardport
This PR was created by @fw-bot
OE
the report is linked to a support ticket (opw-...)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
Issue:
The employee is not placed in the right category of industry. He should be in the same category as the company he works in.
Cause:
When creating a contact, the
industry_id
field is not passed from parent to children.(Moreover, this field being invisible for an "individual" contact, it is not possible to give it a value without using the studio application.)
Solution:
Add
industry_id
to_commercial_fields
.opw-3085032
Forward-Port-Of: #107918