Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][FIX] core: ability to run tours in Chrome 111 #115782

Closed
wants to merge 1 commit into from
Closed

[12.0][FIX] core: ability to run tours in Chrome 111 #115782

wants to merge 1 commit into from

Conversation

marcelsavegnago
Copy link
Contributor

ref. #114930

ping @xmo-odoo

@xmo-odoo @marcelsavegnago
[FIX] core: ability to run tours in Chrome 111
796898d 
Chrome 111 enabled checking of websocket origin: if the WS connection
sends an Origin head which is not whitelisted with the new
`--remote-allow-origins` switch it is rejected.

Turns out websocket-client (amongst others) *does* send an `Origin`,
which trips the check, and means tours immediately break when trying
to run them as Odoo's test harness is unable to connect to (and
control) the devtools.

Suppress sending `Origin` to fix the issue.

Note: this also prevents using the remote developer tools by opening
the devtools URL, user needs to go through chrome://inspect from the
client and find / select the headless browser from there.

Chrome 111 changeset: https://chromiumdash.appspot.com/commit/0154caeefc74530d5cb57ce71608beb1b77bca39

Chrome tracker issue: https://crbug.com/1422444

closes odoo#114930

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
@robodoo
Copy link
Contributor

robodoo commented Mar 17, 2023

Pull request status dashboard.

@C3POdoo C3POdoo requested a review from a team March 17, 2023 22:35
@pedrobaeza
Copy link
Collaborator

Odoo is not accepting patches in these old branches. You should propose it to OCB and use that soft fork.

@rvalyi
Copy link
Contributor

rvalyi commented Mar 18, 2023 •
edited

@pedrobaeza this a bit of a serious issue for us in the OCA, because some tests are broken in the CI for odoo/odoo. It means even if we patch OCA/OCB some tour tests for odoo/odoo will keep failing and cripple some repository CI entirely (example
OCA/l10n-brazil#2388 )

V12 is still quite popular to leave it with a broken CI entirely... Alternatives I see are:

  • disable V12 tour tests one by one as in the example I gave. cons: will be very time consuming.
  • disable tests for offending modules. cons: may be would loose too much test coverage.
  • disable the odoo/odoo tests entirely on offending repos and only keep tests for OCA/OCB. pros: good for the planet.
  • patch the odoo clone somewhat in the OCA CI tooling before running the tests.
  • any other idea?

@rvalyi
Copy link
Contributor

rvalyi commented Mar 18, 2023

bonus idea: monkey path _open_socket in V12 offending tests.
cc @marcelsavegnago

@pedrobaeza
Copy link
Collaborator

Well, maybe Odoo people will merge this, but on the same mood, there are others stucked at 11.0, and anothers at 13.0, so they will demand the same.

The best bet is to modify the OCA CI to only use OCB. At the end, there won't be any counterpart, as there are no more Odoo updates, so if right now is green, the only chance to break it is on OCB. And we will gain less energy consumption in the builds.

@marcelsavegnago
Copy link
Contributor Author

@rvalyi @pedrobaeza For now I did a PR for the OCB too

OCA#1166

@SirTakobi SirTakobi mentioned this pull request Mar 22, 2023
Merged
@SirTakobi SirTakobi mentioned this pull request Mar 23, 2023
Merged
katyukha added a commit to katyukha/Odood that referenced this pull request Mar 28, 2023
@katyukha
Automatically apply patch to run tours on Chrome 111 for Odoo 12
02f0396 
For more info, see:
- odoo/odoo#114930
- odoo/odoo#115782
katyukha added a commit to katyukha/Odood that referenced this pull request Mar 28, 2023
@katyukha
Automatically apply patch to run tours on Chrome 111 for Odoo 12
af444ae 
For more info, see:
- odoo/odoo#114930
- odoo/odoo#115782
katyukha added a commit to katyukha/odoo-helper-scripts that referenced this pull request Mar 28, 2023
@katyukha
Automatically apply patch to run tours on Chrome 111 for Odoo 12.
48b0395 
See details:
  - odoo/odoo#114930
  - odoo/odoo#115782
katyukha added a commit to katyukha/odoo-helper-scripts that referenced this pull request Mar 28, 2023
@katyukha
Release 1.3.0 (2023-03-28)
f966edf 
Added
-----

- Added new option `--no-fetch` to cmd `odoo-helper link` that allows to disable
  fetching repositories (from `odoo_requirements.txt` and `oca_dependencies.txt`)

Changed
-------

- Automatically apply patch to run tours on Chrome 111 for Odoo 12.
  See details:
    - odoo/odoo#114930
    - odoo/odoo#115782

Fixed
-----

- Force link modules during migration tests
@C3POdoo
Copy link
Contributor

C3POdoo commented Apr 16, 2024

Dear @marcelsavegnago,

Thank you for your contribution but the version 12.0 is no longer supported.
We only support the last 3 stable versions so no longer accepts patches into this branch.

We apology if we could not look at your request in time.
If the contribution still makes sense for the upper version, please let us know and do not hesitate to recreate one for the recent versions. We will try to check it as soon as possible.

This is an automated message.

@C3POdoo C3POdoo closed this Apr 16, 2024
@marcelsavegnago marcelsavegnago deleted the 12.0-chrome-111-tours-compatibility-xmo branch April 16, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvalyi rvalyi rvalyi approved these changes

@antoniospneto antoniospneto antoniospneto approved these changes

@SirTakobi SirTakobi SirTakobi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@marcelsavegnago @robodoo @pedrobaeza @rvalyi @C3POdoo @antoniospneto @SirTakobi @xmo-odoo