Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] mrp: timesheet not splitting #116290

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Dotni
Copy link
Contributor

@Dotni Dotni commented Mar 23, 2023

This bug was spotted in the wizard of the workorders allowing to create a timesheet manually.
The previous behaviour did not split the timesheet as it should.

For example: if the duration expected for the workorder is 60 min and if we create a timesheet of 70 min (supposing that no one timesheeted on the workorder),
the timesheets should be splitted in a 60 and a 10 one, with correct loss_ids.

The next step is to make sure that timesheet can merge together. For example, if an employee timesheet ends when another start, with the same productivity, those two should be merged as one

Theses steps must be done in the write and create from mrp.productivity

task id : 3216277

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo
Copy link
Contributor

robodoo commented Mar 23, 2023

@C3POdoo C3POdoo requested a review from a team March 23, 2023 07:42
@Dotni Dotni force-pushed the master-mrp-timesheet_split_merge-marm branch from a39f0cc to 20d6682 Compare March 23, 2023 07:50
@C3POdoo C3POdoo added the RD research & development, internal work label Mar 23, 2023
@Dotni Dotni force-pushed the master-mrp-timesheet_split_merge-marm branch 4 times, most recently from 49fd172 to 4688e0e Compare March 23, 2023 12:31
@Dotni Dotni force-pushed the master-mrp-timesheet_split_merge-marm branch 12 times, most recently from c8e4fb1 to 9af9872 Compare April 7, 2023 11:19
@Dotni Dotni force-pushed the master-mrp-timesheet_split_merge-marm branch from 9af9872 to abb4f14 Compare April 12, 2023 14:58
@Dotni Dotni force-pushed the master-mrp-timesheet_split_merge-marm branch 7 times, most recently from 9ea8325 to 6b89695 Compare April 26, 2023 11:35
This bug was spotted in the wizard of the workorders allowing to create a
timesheet manually.
The previous behaviour did not split the timesheet as it should.

For example: if the duration expected for the workorder is 60 min and
if we create a timesheet of 70 min (supposing that no one timesheeted
on the workorder),
the timesheets should be splitted in a 60 and a 10 one, with correct loss_ids.

The next step is to make sure that timesheet can merge together.
For example, if an employee timesheet ends when another start, with the same productivity, those two should be merged as one

Theses steps must be done in the write and create from mrp.productivity

task id : 3216277
@Dotni Dotni force-pushed the master-mrp-timesheet_split_merge-marm branch 3 times, most recently from 52501ab to caedfb2 Compare June 22, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants