[IMP] mail: better activity info translatability by providing context #116802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
57
to
62
| _t( | ||
| `<span class="fw-bolder %(classes)s }}">%(delay)s:</span> <span class="fw-bolder">%(activity name)s</span> <span class="o-mail-Activity-user">for %(responsible employee)s</span>` | ||
| ), |
There was a problem hiding this comment.
The html should be wrapped inside the getter and not exposed as a translation key.
oomsveta
force-pushed
the
master-fix_activity_info_translation-wil
branch
from
9a79154
to
4986048
Compare
seb-odoo
reviewed
Apr 3, 2023
| return markup( | ||
| sprintf( | ||
| _t( | ||
| `<span class="fw-bolder %(classes)s }}">%(delay)s:</span> %(activity name)s <span class="o-mail-Activity-user">for %(responsible employee)s</span>` |
There was a problem hiding this comment.
I would keep all classes out of translation if possible, it looks like a maintenance nightmare to have them inside.
Even html tags are annoying, but a bit less so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.